Verify origin when upgrading websocket #452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a second test for origin, along with the csrf token, which can be disabled by setting the env var OOD_SHELL_ORIGIN_CHECK to any string not starting with
http
.This by default uses X-Forwarded-Proto and X-Forwarded-Host which Apache mod_proxy should be setting.
It doesn't handle the case where X-Forwarded-Host contains multiple values or it is needed to have multiple valid values to check against - which is why the ability to disable it is present.