Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test ci #3832

Merged
merged 3 commits into from
Sep 30, 2024
Merged

fix test ci #3832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8040669
fix test ci
johrstrom Sep 26, 2024
39b4ebe
fix this typo
johrstrom Sep 26, 2024
ab8d0b6
populate these files instead of just touch
johrstrom Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,17 @@ jobs:
path: ~/vendor/bundle
key: ${{ runner.os }}-${{ matrix.ruby }}-unit-gems-${{ hashFiles('apps/*/Gemfile.lock', 'Gemfile.lock') }}-1

- name: Setup os dependencies
run: |
sudo apt-get update
sudo apt-get install -y rclone libsqlite3-dev

- name: Setup Bundler
run: |
bundle config path ~/vendor/bundle
bundle install
gem install rake

- name: Setup rclone
run: sudo apt-get update && sudo apt-get install rclone

- name: Run unit tests
run: bundle exec rake test:unit

Expand Down
10 changes: 5 additions & 5 deletions apps/dashboard/test/system/files_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,11 +510,11 @@ def setup
dir_to_dl = "#{dir}/test_dir"
`mkdir -p #{dir_to_dl}/first_level_dir`
`mkdir #{dir_to_dl}/.first_level_hidden_dir`
`touch #{dir_to_dl}/real_file`
`touch #{dir_to_dl}/first_level_dir/.second_level_hidden_file`
`touch #{dir_to_dl}/first_level_dir/second_level_real_file`
`touch #{dir_to_dl}/.first_level_hidden_dir/.another_second_level_hidden_file`
`touch #{dir_to_dl}/.first_level_hidden_dir/another_second_level_real_file`
`echo 'abc123' > #{dir_to_dl}/real_file`
`echo 'abc123' > #{dir_to_dl}/first_level_dir/.second_level_hidden_file`
`echo 'abc123' > #{dir_to_dl}/first_level_dir/second_level_real_file`
`echo 'abc123' > #{dir_to_dl}/.first_level_hidden_dir/.another_second_level_hidden_file`
`echo 'abc123' > #{dir_to_dl}/.first_level_hidden_dir/another_second_level_real_file`
Comment on lines -513 to +517
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why I had to change this. This test was failing saying that the directories were empty.

Seems like we used to be able to download empty directories and that's somehow changed? I'd say this needs looking into.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an operating system/du change! I'll open another ticket.


visit files_url(dir)
find('tbody a', exact_text: 'test_dir').ancestor('tr').click
Expand Down
Loading