Regenerate ood-portal.conf when Apache starts or is reloaded #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm good with this. I can't find documentation on having multiple ExecReloads but I'm guessing you know it's ok? If we're ready, I'm ready. |
|
I'd like to test this further with Puppet, because we generate ood-portal.conf with Puppet using generator so this maybe conflict. For |
treydock
added a commit
to OSC/puppet-module-openondemand
that referenced
this pull request
Mar 3, 2020
Address change in OSC/ondemand#371
|
I will just delete the file added with Puppet because the Puppet module expects to be the thing executing ood-portal-generator: OSC/puppet-module-openondemand#23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires some extra testing. Failures from update_ood_portal will not break Apache because the command is prefixed with a hyphen.