Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ace dependency to yarn #3629

Merged
merged 2 commits into from
Jul 18, 2024
Merged

move ace dependency to yarn #3629

merged 2 commits into from
Jul 18, 2024

Conversation

johrstrom
Copy link
Contributor

move ace dependency to yarn, removing it from the public/ directory of the dashboard.

This also upgrade the package (originally committed 7 years ago). Took it for a quick spin and it appears to work as expected.

Oglopf
Oglopf previously approved these changes Jul 8, 2024
Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Contributor

@ashton22305 ashton22305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@johrstrom johrstrom merged commit 90300cb into master Jul 18, 2024
23 checks passed
@johrstrom johrstrom deleted the ace-editor-refactor branch July 18, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants