-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stale pid and socket files #36
Conversation
… stale The reason that files are only removed explicitly if they are stale is Passenger tries to unlink them as part of its shutdown routine and complains when they do not exist.
@treydock is there any reason why always removing stale pid files when calling Is there any utility in retaining stale pid files? I could imagine there would be a case where it would help with diagnosing an issue, but not sure. I'm not sure that The current approach was to not change behavior and add a new flag that removed pid files, but then again user expectation was different:
|
@ericfranz I think removing stale PIDs is fine. I'd suggest writing the removed PID file and the actual PID (if available) to stdout or stderr and then we would update the deployed cron job to look like the following:
This would be the simplest approach for nginx_stage and would still write the output to syslog and not email people the output. I like this because then it's very easy to setup Splunk or other tools to tell me when something pops up in the logs. |
@MorganRodgers lets change nginx clean to always remove stale pid files and just output the stale pid removed to stdout The code should be a whole lot simpler then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
…ove-stale-files Conflicts: nginx_stage/lib/nginx_stage/generators/nginx_clean_generator.rb
Fixes #11.