-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to disable the project size feature #3531
Conversation
3a40e73
to
327d1d7
Compare
Thanks for picking up our issue! I feel like the suggested implementation with setting
I.e., it means an infinite time. I think it's confusing that setting Open3.capture3('timeout', "#{Configuration.project_size_timeout}s", 'du', '-s', #... If you want to go down this route anyway, perhaps setting a negative value could make more sense, since it's "illegal" in the
I'd personally prefer a separate configuration option, like It was also a bit confusing to me that the ondemand/apps/dashboard/app/models/project.rb Lines 188 to 193 in 1a35d7e
It would be good to have a sanity check there that the parameter actually is a positive floating point number, to guard against future changes. Let me know what you think! |
Thanks for the review, will make some improvements based on your comments. |
9696770
to
4f61056
Compare
I have made some improvements based on the comments:
Regarding the validation of the |
k8s tests are broken apparently. I'm fine with the changes, but it appears we need to fix that first. |
4f61056
to
c7bf93d
Compare
Thank you! @abujeda |
It seems that some of the Ubuntu and Debian tests are broken now. |
Triggered a CI build and all tests are green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
This changes disables the project size feature by setting the existingproject_size_timeout
property to 0This changes disables the project size feature by setting a new
Configuration.project_size_enabled
property to falseFixes #3530