Explicitly stringify the values for pun_custom_env #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error where integer values for pun_custom_env would cause TypeErrors: "no implicit conversion of Integer into String".
ericfranz
reviewed
Mar 29, 2019
| @@ -72,7 +72,7 @@ module Configuration | |||
| attr_writer :pun_custom_env | |||
|
|
|||
| def pun_custom_env | |||
| transform_keys(@pun_custom_env) { |key| key.to_s } | |||
| Hash[@pun_custom_env.map {|key, value| [key.to_s, value.to_s]}] | |||
There was a problem hiding this comment.
This would be slightly more readable if the helper method was:
transform_keys_and_values_to_strings(@pun_custom_env)
and the separate method
def transform_keys_and_values_to_strings(obj)
Hash[obj.map {|key, value| [key.to_s, value.to_s]}]
endOr a comment? Of course we have more complex transformations than this that don't have comments that I've written in the past so...
There was a problem hiding this comment.
I elected to remove the other method because it was only used in this one method. It seems unnecessary to shift the main implementation of pun_custom_env to another method if there is no present need to make that section of code re-usable. I am open to the argument that a method to ensure that a Hash's keys and values are strings is useful, but then I question: is NginxStage::Configuration the correct place for such a thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error where integer values for pun_custom_env would cause TypeErrors: "no implicit conversion of Integer into String".
Fixes #26.