start to expand data- entries for auto_queues #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
force-pushed
the
expanded-auto-queues
branch
from
b7a519b
to
90f7b16
Compare
johrstrom
commented
Oct 26, 2023
Comment on lines
+677
to
+679
|
|
||
| option.style.display = 'none'; | ||
| option.disabled = true; |
There was a problem hiding this comment.
I think I had to make this change because it was working by coincidence.
This PR has duplicate options - i.e., options with the same value but different data- directives which we've gone back and forth on, but yea I suspect it was working by coincidence before because there were fewer (or no) duplicate options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts work on #3027 but I'm sure there's a lot here, so in draft while I see how bad the CI is broken.