-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start to expand data- entries for auto_queues #3123
Conversation
b7a519b
to
90f7b16
Compare
|
||
option.style.display = 'none'; | ||
option.disabled = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I had to make this change because it was working by coincidence.
This PR has duplicate options - i.e., options with the same value
but different data-
directives which we've gone back and forth on, but yea I suspect it was working by coincidence before because there were fewer (or no) duplicate options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Starts work on #3027 but I'm sure there's a lot here, so in draft while I see how bad the CI is broken.