Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NodeJS 18 and Ruby 3.1 #2885

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Update to NodeJS 18 and Ruby 3.1 #2885

merged 5 commits into from
Jul 6, 2023

Conversation

treydock
Copy link
Contributor

@treydock treydock commented Jun 21, 2023

NodeJS update affects all OSes except EL7 and Amazon 2023
Ruby 3.1 update only affects EL8 and EL9
Fixes #2884

NodeJS update affects all OSes except EL7 and Amazon 2023
Ruby 3.1 update only affects EL8 and EL9
@treydock treydock requested a review from johrstrom June 21, 2023 23:50
@treydock treydock marked this pull request as ready for review June 21, 2023 23:50
@treydock treydock marked this pull request as draft June 22, 2023 14:06
@treydock treydock marked this pull request as ready for review June 22, 2023 19:54
@treydock
Copy link
Contributor Author

@johrstrom This is now ready for review. Created OSC/ondemand-packaging#249 to create ondemand-bundler package so all supported distros have same version of bundler. Ran into quite a few weird issues when some OSes have old bundler while some have newer.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll. I see this updates the lock file to bundler 2.3.6. That's all good. I suspect there's good backward compatibility for platforms with lower bundler.

@treydock
Copy link
Contributor Author

treydock commented Jul 6, 2023

Let's roll. I see this updates the lock file to bundler 2.3.6. That's all good. I suspect there's good backward compatibility for platforms with lower bundler.

What I observed was that on RHEL8 and RHEL9, with newer bundler, the bundler command would automatically force install of whatever version is in Gemfile.lock. This is a new feature of I think bundler 2.3. I'm working on packaging PR so that OnDemand has a dedicated ondemand-bundler package for all OSes so that every OS can have the same version as I ran into some weird issues with the various versions on each platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJS 14 is EOL
3 participants