Moved support_ticket configuration to UserConfiguration class #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to finish manual testing, but automated tests look good. |
|
I have completed the manual testing locally for both email and RT API implementations. |
johrstrom
reviewed
Mar 2, 2023
johrstrom
reviewed
Mar 2, 2023
johrstrom
reviewed
Mar 2, 2023
johrstrom
reviewed
Mar 2, 2023
johrstrom
reviewed
Mar 2, 2023
abujeda
force-pushed
the
support_ticket_profile_based_config
branch
from
e23e9d8
to
aaeb3a8
Compare
abujeda
force-pushed
the
support_ticket_profile_based_config
branch
from
aaeb3a8
to
5812245
Compare
johrstrom
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated
support_ticketconfiguration fromConfigurationSingletontoUserConfigurationto add profile support.We were doing an internal review and realized that different profiles might have different email or config settings for the support ticket configuration. Or one profile might want to disable the functionality.
The PR looks bigger than it is. It is just that the config was used in a lot of places.
┆Issue is synchronized with this Asana task by Unito