Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for images from /public location #2577

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented Feb 14, 2023

Added support to use images from /public location (eg: /var/www/ood/public).

  • By default, icon_tag helper prefixes image URIs with the application path, /pun/sys/dashboard. This was not allowing to use image deployed in the public Apache folder.
  • This helper is used for pinned apps images and navigation items.
tile:
  title: "RStudio 400"
  icon_uri: "/public/images/rstudio_logo.png"
  border_color: "blue "
  sub_caption: |
    Custom Text Line 1
    Line 2
    Line 3

Pinned apps fixes to the image width when the custom image is wider than the tile.

┆Issue is synchronized with this Asana task by Unito

@abujeda
Copy link
Contributor Author

abujeda commented Feb 14, 2023

Image width fix.
Before:
Screenshot 2023-02-14 at 22 05 23

After:
Screenshot 2023-02-14 at 22 15 12

@johrstrom johrstrom merged commit 2e2da6a into OSC:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants