Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch connect apps to use a per cluster dataroot #1409

Merged
merged 9 commits into from
Sep 29, 2021

Conversation

johrstrom
Copy link
Contributor

@johrstrom johrstrom commented Sep 24, 2021

Fixes #1328

Batch connect apps to use a per cluster dataroot to support sites that have seperate file systems for each cluster.

Surprisingly, all the tests still pass. Mostly because we have stubs for dataroot in all the tests.

This feature should have:

  • tests
  • similar job composer support
  • feature flag
  • find a suitible location for context.json files because they're cluster independent and should only exist on the web node.

batch connect apps to use a per cluster dataroot to support sites
that have seperate file systems for each cluster.
@johrstrom johrstrom marked this pull request as ready for review September 29, 2021 16:45
@johrstrom
Copy link
Contributor Author

I think this is ready. I'm also thinking we should defer job composer feature the context.json issue.

Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

per cluster dataroot for interactive apps
3 participants