Removed the panels classes since they were deprecated in bootstrap 4 … #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and adjusted the css classes to handle the colors.
|
Fixes #993 |
johrstrom
reviewed
Jun 10, 2021
Comment on lines
109
to
112
| .panel-ood-burgundy { | ||
| @include panel-variant($ood-burgundy, $ood-white, $ood-burgundy, $ood-burgundy); | ||
| .systemAppsHeader { | ||
| background-color: $ood-blue; | ||
| color: $ood-white; | ||
| } |
There was a problem hiding this comment.
Does just a s/panel/card work here? You'll have to excuse my ignorance of css variants here.
Whatever we do, I think the names should continue to be snake case with hyphens instead of camel case.
There was a problem hiding this comment.
Agreed on the naming, I'll make that change.
The bootstrap docs specifically called out panels as being no longer supported which is why I removed them altogether since we are using bs 4.6 according to the package.json. Here is the relevant bootstrap doc: https://getbootstrap.com/docs/4.6/components/card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and adjusted the css classes to handle the colors.