Ensure urls in proxies #1105
Merged
Ensure urls in proxies #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
force-pushed
the
ensure-urls-in-proxies
branch
from
b7cb1b9
to
12bfb76
Compare
johrstrom
force-pushed
the
ensure-urls-in-proxies
branch
from
12bfb76
to
d0595df
Compare
johrstrom
commented
May 5, 2021
mod_ood_proxy/lib/node_proxy.lua
Outdated
Comment on lines
41
to
43
| if conn.uri == '' then | ||
| conn.uri = '/' | ||
| end |
There was a problem hiding this comment.
I'm guessing at this point it can never be nil. But looking at it again, should it be
if conn.uri == nil or conn.uri == '' then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1103 and adds a bunch of test cases for testing proxies.