Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files app clean history final #1043

Merged
merged 20 commits into from
Apr 15, 2021

Commits on Apr 14, 2021

  1. Configuration menu
    Copy the full SHA
    3ba3754 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e53d6c View commit details
    Browse the repository at this point in the history
  3. add fluid files layout with files.js pack

    Co-authored-by: Mario Squeo <msqueo@osc.edu>
    ericfranz and msquee committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    7b9a59b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9f7015c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    97383d0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    737455d View commit details
    Browse the repository at this point in the history
  7. files app with nav and file viewing

    UI for the files app with buttons for various actions not yet implemented
    
    basic implementations for:
    
    1. Open In Terminal
    2. Show Dotfiles and Show Owner/Mode (Mario)
    3. Filter box clearing on navigating to new directory (Mario)
    4. Change directory via AJAX by selecting directory, clicking up, or specifying path in Change directory dialog
    5. Copy path button
    6. Sorting by Size and Modified at (Mario)
    
    Co-authored-by: Mario Squeo <msqueo@osc.edu>
    ericfranz and msquee committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    2bc59ac View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ecf5ce3 View commit details
    Browse the repository at this point in the history
  9. impl download files

    ericfranz committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    dbcea38 View commit details
    Browse the repository at this point in the history
  10. impl upload files

    ericfranz committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    69447ed View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f910d82 View commit details
    Browse the repository at this point in the history
  12. impl cp/mv/delete as transfer resource

    - Transfer resource allows executing the action synchronously or asynchronously via ActiveJob
    - When using ActiveJob we use Rails built in support for GlobalID of the Transfer object
    - Transfer manages its own in memory array of Transfer objects
    - Client side, each transfer that is asynchronous has its own polling cycle
    - Server side validations are enforced using ActiveModel validations
    - System tests are added for end to end testing
    ericfranz committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    56557bf View commit details
    Browse the repository at this point in the history
  13. memoize use of Etc.getpwuid

    ericfranz committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    d71bc09 View commit details
    Browse the repository at this point in the history
  14. Note: dir upload includes empty dirs on dnd

    Directory uploads include empty dirs only when a directory upload is initiated via drag and drop
    
    This is due to HTML5 limitations
    
    When using an <input type="file" webkitdirectory> you get back a FileList of File objects
    When using drag and drop you get a transfer object that gives you access to the File and Directory Entries API
    ericfranz committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    8442525 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4df9752 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a23203d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    26115e5 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    6a51bc5 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. fix test

    ericfranz committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    76ca2c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e84f688 View commit details
    Browse the repository at this point in the history