-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files app clean history final #1043
Merged
ericfranz
merged 20 commits into
files_app_clean_history_base
from
files_app_clean_history_final
Apr 15, 2021
Merged
Files app clean history final #1043
ericfranz
merged 20 commits into
files_app_clean_history_base
from
files_app_clean_history_final
Apr 15, 2021
Commits on Apr 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3ba3754 - Browse repository at this point
Copy the full SHA 3ba3754View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e53d6c - Browse repository at this point
Copy the full SHA 9e53d6cView commit details -
add fluid files layout with files.js pack
Co-authored-by: Mario Squeo <msqueo@osc.edu>
Configuration menu - View commit details
-
Copy full SHA for 7b9a59b - Browse repository at this point
Copy the full SHA 7b9a59bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f7015c - Browse repository at this point
Copy the full SHA 9f7015cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97383d0 - Browse repository at this point
Copy the full SHA 97383d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 737455d - Browse repository at this point
Copy the full SHA 737455dView commit details -
files app with nav and file viewing
UI for the files app with buttons for various actions not yet implemented basic implementations for: 1. Open In Terminal 2. Show Dotfiles and Show Owner/Mode (Mario) 3. Filter box clearing on navigating to new directory (Mario) 4. Change directory via AJAX by selecting directory, clicking up, or specifying path in Change directory dialog 5. Copy path button 6. Sorting by Size and Modified at (Mario) Co-authored-by: Mario Squeo <msqueo@osc.edu>
Configuration menu - View commit details
-
Copy full SHA for 2bc59ac - Browse repository at this point
Copy the full SHA 2bc59acView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecf5ce3 - Browse repository at this point
Copy the full SHA ecf5ce3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dbcea38 - Browse repository at this point
Copy the full SHA dbcea38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69447ed - Browse repository at this point
Copy the full SHA 69447edView commit details -
Configuration menu - View commit details
-
Copy full SHA for f910d82 - Browse repository at this point
Copy the full SHA f910d82View commit details -
impl cp/mv/delete as transfer resource
- Transfer resource allows executing the action synchronously or asynchronously via ActiveJob - When using ActiveJob we use Rails built in support for GlobalID of the Transfer object - Transfer manages its own in memory array of Transfer objects - Client side, each transfer that is asynchronous has its own polling cycle - Server side validations are enforced using ActiveModel validations - System tests are added for end to end testing
Configuration menu - View commit details
-
Copy full SHA for 56557bf - Browse repository at this point
Copy the full SHA 56557bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for d71bc09 - Browse repository at this point
Copy the full SHA d71bc09View commit details -
Note: dir upload includes empty dirs on dnd
Directory uploads include empty dirs only when a directory upload is initiated via drag and drop This is due to HTML5 limitations When using an <input type="file" webkitdirectory> you get back a FileList of File objects When using drag and drop you get a transfer object that gives you access to the File and Directory Entries API
Configuration menu - View commit details
-
Copy full SHA for 8442525 - Browse repository at this point
Copy the full SHA 8442525View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4df9752 - Browse repository at this point
Copy the full SHA 4df9752View commit details -
Configuration menu - View commit details
-
Copy full SHA for a23203d - Browse repository at this point
Copy the full SHA a23203dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26115e5 - Browse repository at this point
Copy the full SHA 26115e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a51bc5 - Browse repository at this point
Copy the full SHA 6a51bc5View commit details
Commits on Apr 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 76ca2c4 - Browse repository at this point
Copy the full SHA 76ca2c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e84f688 - Browse repository at this point
Copy the full SHA e84f688View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.