Merge activejobs into the dashboard #1033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wide columns and extra classes for borders and stripes.
updates to get activejobs to work in the dashboard
johrstrom
added
breaking change
ericfranz
previously approved these changes
Apr 8, 2021
|
closing in favor of #1034 which is effectively the same set of changes but with a cleaner git history than this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the merge of activejobs into the dashboard.
It does not handle redirections from
/pun/sys/activejobs->/pun/sys/dashboard/activejobs. That URL will fail if folks have it bookmarked.This will also not work until certain commits from the Files app PR are pulled in (namely 71ea3b0 and 061eaaf)
It Introduces the following breaking changes:
/etc/ood/config/apps/activejobs/initializers. These will have move to the dashboard's initializer config directory./etc/ood/config/apps/envare no longer read. Though this breaks behaviour it actually more convienient becuase any environment variable defined here is likely shared with the dashboard./etc/ood/config/apps/activejobs/viewsare no longer read. These will have move to the dashboard's custom view config directory.Filteris nowActiveJobs::Filter. This will break initializers.