Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic batch connect apps #851

Closed
5 tasks done
johrstrom opened this issue Jan 19, 2021 · 2 comments
Closed
5 tasks done

dynamic batch connect apps #851

johrstrom opened this issue Jan 19, 2021 · 2 comments
Labels
area/installation component/batch_connect enhancement This is functionality that builds upon existing functionality. epic Very large tickets
Milestone

Comments

@johrstrom
Copy link
Contributor

johrstrom commented Jan 19, 2021

I know we've talked about this, but I don't know if there's any ticket for the actual feature. Looks like we worked on #513 but decided against it, though I'm not sure if we decided against the approach in the PR or the idea altogether.

We have a similar approach in our own BC apps, so maybe our jquery javascript approach may be mature enough.

I think the result could be something like setting for node types.

    options:
      - [
          "any",     "any",
          data-min-ppn-for-cluster-owens: 1,
          data-max-ppn-for-cluster-owens: 28,
          data-min-ppn-for-cluster-pitzer: 1,
          data-max-ppn-for-cluster-pitzer: 48,
          data-option-for-cluster-owens: true,
          data-option-for-cluster-pitzer: true
        ]

data-option-for-<ATTRIBUTE>-<ATTRIBUTE VALUE>

  • would register a handler and show/disable the given option or field when the attribute changed to the specific value. We do this now in our batch connect apps.

data-[min,max]-<CORES ATTRIBUTE>-for-<CHANGE ATTRIBUTE>-<ATTRIBUTE VALUE>

  • would register a handler to change the mins and maxes of CORES ATTRIBUTE when CHANGE ATTRIBUTE is set to CHANGE ATTRIBUTE VALUE.

These are common patterns we see all the time, needing to hide something based off of a selected value and changing mins and maxes. Is this approach generic enough to pick up other use cases? maybe not, but maybe we don't need to worry about every use case just yet. This may provide a lot of value for folks.

Here's what's complete and what's still to do.

┆Issue is synchronized with this Asana task by Unito

@johrstrom
Copy link
Contributor Author

I'm going to break this ticket up. options for handlers were added in #1380, we'll make other tickets for other features.

@johrstrom johrstrom added the epic Very large tickets label Oct 27, 2021
@johrstrom johrstrom assigned johrstrom and unassigned KinanAlAttar Oct 27, 2021
@johrstrom johrstrom modified the milestones: Backlog, OOD2.1 Oct 27, 2021
@johrstrom johrstrom changed the title Add javascript helpers for commonly used patterns in batch connect apps dynamic batch connect apps Apr 25, 2022
@lukew3 lukew3 added the enhancement This is functionality that builds upon existing functionality. label Jun 30, 2022
@Oglopf Oglopf added component/dashboard bug Existing functionality not working as expected and removed bug Existing functionality not working as expected component/dashboard labels Dec 5, 2022
@johrstrom
Copy link
Contributor Author

This is actually in 2.0 as well, but will be in 2.1 with some bugfixes that 2.0 may not have.

@johrstrom johrstrom removed their assignment Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installation component/batch_connect enhancement This is functionality that builds upon existing functionality. epic Very large tickets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants