Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Safari alert by default #608

Closed
ericfranz opened this issue Jul 24, 2020 · 3 comments · Fixed by #629
Closed

Hide Safari alert by default #608

ericfranz opened this issue Jul 24, 2020 · 3 comments · Fixed by #629
Assignees
@msquee
Milestone
OOD1.8

Comments

@ericfranz
Copy link
Contributor

Now that we are using Dex as the default recommendation for authentication, we should not require sites to configure OnDemand to disable the Safari alert.

screen 2020-07-24 at 12 01 30 PM
@oscwiag oscwiag added this to the Needs Triaged milestone Jul 24, 2020
@msquee
Copy link
Contributor

msquee commented Jul 24, 2020

@ericfranz Should this error message be completely removed along with the DISABLE_SAFARI_BASIC_AUTH_WARNING environment variable?

Since Dex is enabled by default, I don't think a site would explicitly enable HTTP Basic Authentication over Dex.

@msquee msquee self-assigned this Jul 24, 2020
@ericfranz ericfranz modified the milestones: Needs Triaged, OOD1.8 Aug 4, 2020
@ericfranz
Copy link
Contributor Author

You still have to manually install Dex. But maybe we should remove it completely.

@ericfranz ericfranz mentioned this issue Aug 4, 2020
Closed
@ericfranz
Copy link
Contributor Author

OSC/ood-documentation#333

msquee added a commit that referenced this issue Aug 5, 2020
@msquee
Remove Safari compatibility alert (#608)
941e627 
* Dex is now the default recommendation for auth instead of Basic Auth
@msquee msquee mentioned this issue Aug 5, 2020
Merged
ericfranz added a commit that referenced this issue Aug 5, 2020
@ericfranz
Merge pull request #629 from OSC/update/remove-safari-warning
07a9cd6 
Remove Safari compatibility alert (#608)
@ericfranz ericfranz mentioned this issue Aug 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msquee msquee

Labels
None yet
Projects
None yet
Milestone
OOD1.8
Development

Successfully merging a pull request may close this issue.

Remove Safari compatibility alert (#608) OSC/ondemand
3 participants
@ericfranz @msquee @oscwiag