Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cluster to override OOD_BC_SSH_TO_COMPUTE_NODE #1157

Closed
treydock opened this issue May 21, 2021 · 0 comments · Fixed by #1173
Closed

Allow cluster to override OOD_BC_SSH_TO_COMPUTE_NODE #1157

treydock opened this issue May 21, 2021 · 0 comments · Fixed by #1173

Comments

@treydock
Copy link
Contributor

Right now with Kubernetes, once the Session is ready there is a link to the Kubernetes worker node that attempts to establish SSH to that worker node. That will not work for OSC Kubernetes deployment, and likely won't work for most Kubernetes deployments. It would be ideal if a cluster YAML could override the setting pulled from OOD_BC_SSH_TO_COMPUTE_NODE.

@oscwiag oscwiag added this to the Needs Triaged milestone May 21, 2021
treydock added a commit to OSC/ood_core that referenced this issue May 21, 2021
…to a new setting:

batch_connect:
  ssh_allow: <boolean>
Needed for OSC/ondemand#1157
johrstrom pushed a commit to OSC/ood_core that referenced this issue May 26, 2021
…to a new setting (#286)

* Add cluster batch_connect_ssh_allow? function to allow easier access to a new setting:
batch_connect:
  ssh_allow: <boolean>
Needed for OSC/ondemand#1157

* Remove default from API of batch_connect_ssh_allow?
johrstrom pushed a commit that referenced this issue Jun 21, 2021
* Allow cluster to override OOD_BC_SSH_TO_COMPUTE_NODE
Fixes #1157

* Use methods to determine if allowing SSH to compute nodes

* Fix unit tests

* Improved logic for ssh_to_compute_node?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants