extending drsdtcon with regimes, and option for GAS/WATER #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2024
totto82
reviewed
Jun 7, 2024
| @@ -123,7 +121,7 @@ drsdtActive(int episodeIdx) const | |||
| const auto& oilVaporizationControl = schedule_[episodeIdx].oilvap(); | |||
| const bool bothOilGasActive = FluidSystem::phaseIsActive(FluidSystem::oilPhaseIdx) && | |||
| FluidSystem::phaseIsActive(FluidSystem::gasPhaseIdx); | |||
| return (oilVaporizationControl.drsdtActive() && bothOilGasActive); | |||
| return (oilVaporizationControl.drsdtActive()); | |||
| @@ -113,7 +112,6 @@ init(std::size_t numDof, int episodeIdx, const unsigned ntpvt) | |||
| if (this->drsdtConvective(episodeIdx)) { | |||
| @@ -101,8 +101,7 @@ init(std::size_t numDof, int episodeIdx, const unsigned ntpvt) | |||
| //TODO We may want to only allocate these properties only if active. | |||
| //But since they may be activated at later time we need some more | |||
| //intrastructure to handle it | |||
| if (FluidSystem::phaseIsActive(FluidSystem::oilPhaseIdx) && | |||
| FluidSystem::phaseIsActive(FluidSystem::gasPhaseIdx)) { | |||
|
|
|||
There was a problem hiding this comment.
I still think we should add a if here, but it should be a bit more fine-tuned. Something like
If (drsdt)
resize: maxDRs and lastRs_ and dRsDtOnlyFreeGas_
if(drvdt)
resize: maxDrv and lastRv
| // Note that for so = 0 this gives no limits (inf) for the dissolution rate | ||
| // Also we restrict the effect of convective mixing to positive density differences | ||
| // i.e. we only allow for fingers moving downward | ||
|
|
There was a problem hiding this comment.
Since we also support gas-water case, maybe adapt the comment?
| @@ -174,6 +174,7 @@ class EquilInitializer | |||
| const auto& h = FluidSystem::enthalpy(fluidState, phaseIdx, regionIdx); | |||
| fluidState.setEnthalpy(phaseIdx, h); | |||
| } | |||
|
|
|||
| } | |||
There was a problem hiding this comment.
Nitpick. Please remove the added line.
opm/simulators/flow/FlowProblem.hpp
Outdated
| @@ -520,6 +524,8 @@ class FlowProblem : public GetPropType<TypeTag, Properties::BaseProblem> | |||
| const auto& schedule = simulator.vanguard().schedule(); | |||
| const auto& events = schedule[episodeIdx].events(); | |||
|
|
|||
|
|
|||
|
|
|||
| if (episodeIdx >= 0 && events.hasEvent(ScheduleEvents::GEO_MODIFIER)) { | |||
There was a problem hiding this comment.
Nitpick. Please remove the added line.
added 2 commits
June 28, 2024 13:49
…g to drsdtcon, fixed indentation and bug in lastRs for gas/water
Merged
|
I will close this since its content is part of #5491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the DRSDTCON to include more parameters that controls the regime and rate of convective mixing.
Included a convective term in the transport flux for the brine.
Also works for GAS/WATER (not only GAS/OIL as before)
Has corresponding PR in opm-models (OPM/opm-models#902) and opm-common (OPM/opm-common#4097)