Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Action Messages to Debug File #4251

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

bska
Copy link
Member

@bska bska commented Oct 8, 2024

This appears to have been inadvertently missed in commit 8a77f5b (PR #4234) which, as a consequence, partially reverted commit 6b94c50 (PR #3112).

This appears to have been inadvertently missed in commit 8a77f5b
(PR OPM#4234).
@bska
Copy link
Member Author

bska commented Oct 8, 2024

jenkins build this please

Copy link
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops. darn list-of-bools-with-default-values bites again. Sorry about that.

@akva2 akva2 merged commit 827f05e into OPM:master Oct 9, 2024
1 check passed
@bska
Copy link
Member Author

bska commented Oct 9, 2024

darn list-of-bools-with-default-values bites again.

Yeah... Default values in general are a pain, but it's amplified when it's bools–especially if there are multiple such parameters in a row.

@bska bska deleted the apply-action-log-to-debug branch October 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants