Add Missing UDA Dimension for GCONPROD GRAT Limit #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
I assume this get some test coverage in upcoming work? |
bska
force-pushed
the
fix-missing-rst-gconprod-uda-grat-dim
branch
from
6b2f702 to
0f133c8
Compare
Kind of. I've pushed an update to the unit tests for |
|
jenkins build this please |
bska
force-pushed
the
fix-missing-rst-gconprod-uda-grat-dim
branch
from
0f133c8 to
dcffab5
Compare
|
jenkins build this please |
akva2
approved these changes
Oct 8, 2024
|
PR approved and build check is green. I'll merge into the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears to have been simply forgotten when this function was first added in commit d8d6749 (PR #2620). Without this we fail loading a restarted simulation run with UDAs for GCONPROD's GRAT limit and issue a diagnostic of the form