Recognize .GRID/.FGRID File Types #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
bska
force-pushed
the
cvrt-grid-fgrid
branch
from
330770a to
3ef1a1f
Compare
|
jenkins build this please |
bska
force-pushed
the
cvrt-grid-fgrid
branch
from
3ef1a1f to
efafc71
Compare
|
jenkins build this please |
akva2
reviewed
Sep 18, 2024
test_util/convertECL.cpp
Outdated
| auto search = to_binary.find(extension); | ||
|
|
||
| if (search != to_binary.end()){ | ||
| resFile = rootN + search->second; | ||
| } else if (extension.substr(1,1)=="F"){ | ||
| } | ||
| else if (extension.substr(1,1)=="F"){ |
There was a problem hiding this comment.
spacing while at it (and below)
Right. I've pushed an update to that effect, including in a few other locations in the file.
The I/O code and simulator does not support this grid type, but we should nevertheless be able to convert between the formatted and the unformatted version of this file.
bska
force-pushed
the
cvrt-grid-fgrid
branch
from
efafc71 to
c94d43d
Compare
|
jenkins build this please |
akva2
approved these changes
Sep 18, 2024
|
PR approved and build check is green. I'll merge into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The I/O code and simulator does not support this grid type, but we should nevertheless be able to convert between the formatted and the unformatted version of this file.