Fix wetting phase hysteresis #4160
Conversation
|
jenkins build this please |
|
jenkins build this please |
There was a problem hiding this comment.
I have no particular opinion on the code itself, but the PR description leaves a little something to be desired in my opinion
Follow the formulation as in Killough 1976 more naivly
What does "naively" mean in this context? Did you mean "closely" or some other adjective adverb?
|
"Accuracy " or "correctly" is maybe better. I misunderstood some details in the first implementation and mixed-up the formulation when I tried to simplify it a bit. This time I just "naively" implement it as written in the paper. |
Ah, okay, so maybe "faithfully" would be a more accurate description? |
Should I interpret this as an approval. I.e. Can I merge this? |
Please amend the commit message with a more descriptive word than "naively". Then this is good to go. |
Follow the formulation as in Killough 1976 more faithfully The earlier implementation contained some bugs and simplifications that this commit fixes. Most importantly the nonwetting phase saturation is used to determine the turning points also for the wetting phase hysteresis.
|
jenkins build this please |
2 similar comments
|
jenkins build this please |
|
jenkins build this please |
Follow the formulation as in Killough 1976 more naivly
Most importantly the nonwetting phase saturation is used to determine the turning points.