Add option for GMST output #4060
Conversation
|
jenkins build this opm-simulators=5344 please |
There was a problem hiding this comment.
The code changes look good apart from a couple of minor issues. I do have one organisational remark though: If these are OPM-specific summary vectors, then they should really be defined/declared in 900_OPM/F/FIELD_PROBE_OPM and 900_OPM/R/REGION_PROBE_OPM instead of in the "compatible" section.
| @@ -40,6 +40,7 @@ | |||
| "RGCDI", | |||
| "RGCDM", | |||
| "RGDEN", | |||
| "RFMST", | |||
There was a problem hiding this comment.
Did you mean RGMST instead of RFMST here?
opm/output/eclipse/Inplace.cpp
Outdated
| @@ -233,6 +233,8 @@ const std::vector<Inplace::Phase>& Inplace::mixingPhases() | |||
| Inplace::Phase::CO2MassInGasPhaseMob, | |||
| Inplace::Phase::CO2MassInGasPhaseInMobKrg, | |||
| Inplace::Phase::CO2MassInGasPhaseMobKrg, | |||
| Inplace::Phase::CO2MassInGasPhaseEffectiveTrapped, | |||
| Inplace::Phase::CO2MassInGasPhaseMaksimumTrapped, | |||
There was a problem hiding this comment.
Maybe we could spell this as MaximumTrapped instead of MaksimumTrapped?
|
The value of CO2MassInGasPhaseMaximumTrapped /GMTR are much higher than expected. (even higher than the total mass of co2 in gas) I temporary set make this draft while investigating. |
|
I had to rename GMTR as summary keywords ending with TR are used for tracers. |
|
jenkins build this opm-simulators=5344 please |
1 similar comment
|
jenkins build this opm-simulators=5344 please |
| @@ -606,7 +610,7 @@ class EclHysteresisTwoPhaseLawParams : public EnsureFinalized | |||
| // for non WAG hysteresis we still keep track of the process | |||
| // for output purpose. | |||
| if (!gasOilHysteresisWAG()) { | |||
| if (krnSw < krnSwMdc_) { | |||
| if (krnSw <= krnSwMdc_) { | |||
There was a problem hiding this comment.
If you're changing this anyway, you might as well just write
this->isDrain_ = ! (krnSw > this->krnSwMdc_);instead.
[FR]GMST output the effective trapped CO2 in the gas phase [FR]GMUS output the effective untrapped CO2 in gas phase Also rename GMTR to GMIM as endings with TR is used for tracers
|
jenkins build this opm-simulators=5344 please |
1 similar comment
|
jenkins build this opm-simulators=5344 please |
GMST output the stranded CO2 in the gas phase as discussed in https://docs.opengosim.com/theory/residual_and_stranded/