Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Featrue]: Encoding #13

Closed
wants to merge 2 commits into from

Conversation

xTwo56
Copy link
Contributor

@xTwo56 xTwo56 commented Apr 9, 2024

Description

label encoded three data columns

Semver Changes

  • Minor (new features, no breaking changes)

Issues

#11

Checklist

Copy link
Collaborator

@Dev7g Dev7g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are commiting two new files, which is against the contribution guidelines.

The changes must be done within the Accomodating_Insights.inpyb file.

@TheMimikyu TheMimikyu added PR:Review Pr is under review and can/will need some changes Type:Medium Pr is accepted with difficulty level as medium Semver:minor Pr will force a minor update in repo and includes new features and backward compatibility labels Apr 11, 2024
Copy link
Collaborator

@TheMimikyu TheMimikyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xTwo56 Kindly remove .ipynb_checkpoints folder. It is polluting the codebase.
Your last PR had it which caused the issue.

@TheMimikyu
Copy link
Collaborator

@xTwo56 neighbourhood_group , neighbourhood and room_type are still of object types. Also, note that the changes have to be made in dff dataframe not df.

Data columns (total 12 columns):
 #   Column                          Non-Null Count  Dtype  
---  ------                          --------------  -----  
 0   neighbourhood_group             48884 non-null  object 
 1   neighbourhood                   48884 non-null  object 
 2   latitude                        48884 non-null  float64
 3   longitude                       48884 non-null  float64
 4   room_type                       48884 non-null  object 
 5   price                           48884 non-null  int64  
 6   minimum_nights                  48884 non-null  int64  
 7   number_of_reviews               48884 non-null  int64  
 8   reviews_per_month               38833 non-null  float64
 9   calculated_host_listings_count  48884 non-null  int64  
 10  availability_365                48884 non-null  int64  
 11  price_log                       48884 non-null  float64

No Label Encoding has been done. Thus I'm closing the PR. You may create a new PR when you actually solve the issue.

@TheMimikyu TheMimikyu closed this Apr 11, 2024
@TheMimikyu TheMimikyu added PR:Reject Pr has been rejected as it doesnt follow the guildlines and removed PR:Review Pr is under review and can/will need some changes labels Apr 11, 2024
@xTwo56 xTwo56 deleted the feat_encoding branch April 11, 2024 20:26
@xTwo56 xTwo56 mentioned this pull request Apr 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Reject Pr has been rejected as it doesnt follow the guildlines Semver:minor Pr will force a minor update in repo and includes new features and backward compatibility Type:Medium Pr is accepted with difficulty level as medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants