Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UWP sample build, bump default build number #2496

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Feb 2, 2024

Proposed changes

  • Fix build in samples repo
  • bump build number to express the diff to the first 1.5.372 release

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5afbd81) 52.22% compared to head (90147e4) 53.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2496      +/-   ##
==========================================
+ Coverage   52.22%   53.93%   +1.70%     
==========================================
  Files         316      334      +18     
  Lines       61821    64425    +2604     
  Branches    12726    13226     +500     
==========================================
+ Hits        32284    34745    +2461     
+ Misses      26016    25929      -87     
- Partials     3521     3751     +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen marked this pull request as ready for review February 5, 2024 17:49
@EthanChangAED EthanChangAED added this to the 1.5.373 January Update milestone Feb 6, 2024
@mrsuciu mrsuciu merged commit 591ceb0 into master Feb 6, 2024
71 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants