Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDS Client] Fix Certificate Request when private Key of existing Certificate is not exportable #607

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[GDS Client] Fix Certificate Request when private Key of existing Certificate is not exportable #607

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33cd390
only use CSR when Private Key is exportable
romanett May 12, 2024
14d3dee
ask user before proceeding with new keypair request
romanett Jul 2, 2024
e64cfc5
Merge branch 'master' into fixRequestWhenPrivateKeyIsNotExportable
romanett Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions Samples/GDS/Client/Controls/ApplicationCertificateControl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
* http://opcfoundation.org/License/MIT/1.00/
* ======================================================================*/

using Opc.Ua.Gds;
using Opc.Ua.Security.Certificates;
using System;
using System.Drawing;
Expand Down Expand Up @@ -236,10 +235,35 @@ private async Task RequestNewCertificatePullMode(object sender, EventArgs e)
SubjectName = Utils.ReplaceDCLocalhost(m_application.CertificateSubjectName)
};
m_certificate = await id.Find(true);
//only use CSR when the private key is available & exportable
if (m_certificate != null &&
m_certificate.HasPrivateKey)
{
m_certificate = await id.LoadPrivateKey(m_certificatePassword);
try
{
//this line fails with a CryptographicException if export of private key is not allowed
_ = m_certificate.GetRSAPrivateKey().ExportParameters(true);
//proceed with a CSR using the exportable private key
m_certificate = await id.LoadPrivateKey(m_certificatePassword);
}
catch
{
DialogResult result = MessageBox.Show(
Parent,
"Private key of the selected application certificate is not exportable. \n Creating a Certificate Signing request therefore is not possible \n " +
"Do you want to retrieve a new certificate from the GDS using a key pair request?",
Parent.Text,
MessageBoxButtons.YesNo,
MessageBoxIcon.Exclamation);

if (result == DialogResult.No)
{
return;
}

//use KeyPair Request instead
m_certificate = null;
}
}
}

Expand Down
Loading