core: pager can use memory between SRAM start and core load address #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenswi-linaro
approved these changes
Sep 21, 2017
core/arch/arm/kernel/generic_boot.c
Outdated
| @@ -299,6 +297,10 @@ static void init_runtime(unsigned long pageable_part) | |||
| tee_pager_add_pages((vaddr_t)__pageable_start + init_size, | |||
| (pageable_size - init_size) / SMALL_PAGE_SIZE, true); | |||
|
|
|||
| /* Pager can also use pages before unpaged memory if any */ | |||
There was a problem hiding this comment.
It could be worth commenting on when and why there may be pages before unpaged memory.
|
@etienne-lms can you please rebase and address the conflicts with master? |
|
ok |
|
@etienne-lms I think you could have just applied Jens' R-b, no? Did you change something significant that he did not acknowledge? |
|
ok, i apply and squash. |
If core is loaded some 4kB pages above the start of the physical internal ram, some 4kB memory block will not be used by the pager. This situation can occur if the beginning of the internal ram is used by a bootloader. Bootloader must load op-tee above its own used memory. Such bootloader memory is freely available to op-tee core (pager). This change adds the physical memory between TEE RAM base address and the op-tee entry point address to the pager page pool. This change also default maps this area so that pager identifies physical pages as valid page addresses. This changes fixes the plat-vexpress against CFG_TEE_RAM_START being different from CFG_TEE_LOAD_ADDR. Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If core is loaded some 4kB pages above the start of the physical internal ram, some 4kB memory block will not be used by the pager.
This situation can occur if the beginning of the internal ram is used by a bootloader. Bootloader must load op-tee above its own used memory. Such bootloader memory is freely available to op-tee core (pager).
This change adds the physical memory between TEE RAM base address and the op-tee entry point address to the pager page pool. This change also default maps this area so that pager identifies physical pages as valid page addresses.
I found this issue while verifying support for various locations of a flat mapped coherent memory.