Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu_v8: recent QEMU requires libfdt 1.4.2 or higher #156

Closed
wants to merge 4 commits into from
Closed

qemu_v8: recent QEMU requires libfdt 1.4.2 or higher #156

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
382e923
qemu_v8: recent QEMU requires libfdt 1.4.2 or higher
etienne-lms Jul 3, 2017
e569292
[review] qemu_v8: recent QEMU requires libfdt 1.4.2 or higher
etienne-lms Jul 3, 2017
5108bed
[review] qemu_v8: recent QEMU requires libfdt 1.4.2 or higher
etienne-lms Jul 3, 2017
fd4bbfd
[review] qemu_v8: recent QEMU requires libfdt 1.4.2 or higher
etienne-lms Jul 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion qemu_v8.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ arm-tf-clean:
# QEMU
################################################################################
qemu:
cd $(QEMU_PATH); ./configure --target-list=aarch64-softmmu\
cd $(QEMU_PATH); \
dpkg --compare-versions 1.4.2 le \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to compare etc? It seems like QEMU defaults to the locally checked out version if there is any, otherwise it will use the hosts version. So, I guess line 71 only is sufficient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, always rely on the cloned dtc package.

`dpkg-query --showformat='$${Version}' --show libfdt-dev` || \
git submodule update --init dtc && \
./configure --target-list=aarch64-softmmu \
$(QEMU_CONFIGURE_PARAMS_COMMON)
$(MAKE) -C $(QEMU_PATH)

Expand Down