Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #9

Merged
merged 44 commits into from
Jul 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
39e4ef2
TEDXDC-143 - Added comments for sequence of elements/BTs for efac:Not…
pdonohoe May 19, 2022
36b5053
TEDXDC-143 - Separated main elements within efac:NoticeResult into na…
pdonohoe May 23, 2022
449e073
TEDXDC-156: Add templates for VAL_TOTAL and VAL_RANGE_TOTAL
nhajlaoui May 25, 2022
6888ed3
TEDXDC-183 Added Winner Size (BT-165) to all Organisations; and a WAR…
pdonohoe May 31, 2022
14f9773
TEDXDC-186 Output list of efac:TenderingParty elements
pdonohoe May 31, 2022
a875380
TEDXDC-157: there is no equivalent BT to LOT_DIVISION. There are no c…
nhajlaoui Jun 2, 2022
b484d86
Merge branch 'feature/TEDXDC-135-CAN-F03' of https://github.com/OP-TE…
nhajlaoui Jun 2, 2022
c77e771
TEDXDC-185:
pdonohoe Jun 7, 2022
f78e3e3
Added cac:TenderResult/cbc:AwardDate required by the ContractAwardNot…
pdonohoe Jun 7, 2022
06e1e96
TEDXDC-161: conversion of AWARD_CONTRACT_WITHOUT_CALL, 352425_2021.xm…
nhajlaoui Jun 10, 2022
1accac0
Merge branch 'feature/TEDXDC-135-CAN-F03' of https://github.com/OP-TE…
nhajlaoui Jun 10, 2022
76024b3
TEDXDC: Update templates to cater for empty FRAMEWORK element
nhajlaoui Jun 20, 2022
1cccd7a
TEDXDC-163: Update template to cater for INFO_ADD_EAUCTION not presen…
nhajlaoui Jun 22, 2022
de5a567
TEDXDC-184 - Added template to create efac:LotResult
pdonohoe Jun 27, 2022
91bfadb
TEDXDC-165 and TEDXDC-164 : Create templates to cater for TERMINATION…
nhajlaoui Jun 28, 2022
b834919
TEDXDC-163 - refactored template to ensure comments for BT-767, BT-12…
pdonohoe Jun 28, 2022
8635325
Fixed bug where sequence was used instead of a predicate
pdonohoe Jun 29, 2022
f2bdb15
TEDXDC-156: adapted templates for VAL_TOTAL and VAL_RANGE_TOTAL
nhajlaoui Jun 29, 2022
ed38633
Merge branch 'feature/TEDXDC-135-CAN-F03' of https://github.com/OP-TE…
nhajlaoui Jun 29, 2022
9df1db4
TEDXDC-192: Create template to cater for TITLE in AWARD_CONTRACT
nhajlaoui Jun 30, 2022
d076f0f
TEDXDC-190 - Added code for Contract Framework Agreement (BT-768)
pdonohoe Jul 4, 2022
a3dead2
TEDXDC-156 - Added code for AWARD_CONTRACT/VAL_RANGE_TOTAL. Added tes…
pdonohoe Jul 5, 2022
377807d
TEDXDC-192: update template to cater for TITLE in AWARD_CONTRACT
nhajlaoui Jul 6, 2022
31184be
TEDXDC-178 - used only NUTS level 3 codes for addresses; fixed some m…
pdonohoe Jul 7, 2022
4399631
TEDXDC-201 Added Result Lot Identifier (BT-13713)
pdonohoe Jul 8, 2022
7375f0d
TEDXDC-155 Updated code to ensure comments for "contact" elements are…
pdonohoe Jul 11, 2022
628f28b
TEDXDC-202 and TEDXDC-203: Added Tender Lot Identifier (BT-13714), Te…
pdonohoe Jul 12, 2022
4df937a
TEDXDC-204 Added Tender Identifier Reference (OPT-320) and Contract I…
pdonohoe Jul 13, 2022
e41c49a
TEDXDC-193: Created template to cater for PROCUREMENT_DISCONTINUED an…
nhajlaoui Jul 13, 2022
1fd54a1
TEDXDC-193: Updated warning message for BT-144
pdonohoe Jul 13, 2022
d6c93f8
TEDXDC-195: created template to cater for TENDERS
nhajlaoui Jul 14, 2022
7f024ff
Merge branch 'feature/TEDXDC-135-CAN-F03' of https://github.com/OP-TE…
nhajlaoui Jul 14, 2022
cf193ea
TEDXDC-196: updated templates to cater for VALUES
nhajlaoui Jul 18, 2022
8ae852c
TEDXDC-81 - Added code to handle QUALIFICATION. Updated code to avoid…
pdonohoe Jul 18, 2022
de97760
TEDXDC-74: Completed code for Buyer Legal Type (BT-11) and Buyer Cont…
pdonohoe Jul 19, 2022
3f7e83a
TEDXDC-156: update templates for VAL_TOTAL and VAL_RANGE_TOTAL
nhajlaoui Jul 19, 2022
052ce06
TEDXDC-197: created template to cater for subcontracting elements
nhajlaoui Jul 20, 2022
b51b0b9
TEDXDC-196 : Created named template for Framework Estimated Value (BT…
pdonohoe Jul 20, 2022
a666a9a
TEDXDC-197: improve template to cater for subcontracting elements
nhajlaoui Jul 22, 2022
61c3309
TEDXDC-196 - added item to ted-elements-not-convertible.md for VAL_ES…
pdonohoe Jul 25, 2022
27c3d9f
TEDXDC-211 - Tidied up XSLT, added missing eForms XML files, final co…
pdonohoe Jul 28, 2022
77f6cf6
Merge pull request #8 from OP-TED/feature/TEDXDC-135-CAN-F03
nhajlaoui Jul 28, 2022
e99aee3
TEDXDC-211 - Added Release notes and updated README.md
pdonohoe Jul 28, 2022
ab915d7
Merge branch 'main' into develop
pdonohoe Jul 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
# TED XML Data Converter 0.3.0 Release Notes
Below is a list of the updates made to the Converter repository in this release.

## Contract Notices
Templates have been added to convert elements in TED XML Contract Notice forms F05, F12, F21, F22, F23, F24
# TED XML Data Converter 0.4.0 Release Notes

## Bug fixes and minor changes
## Contract Award Notices - TED form F03

* Missing listName attributes have been added, and some listName attribute values have been corrected.
* Additional CPV codes are now included
* TED XML element ADDRESS_FURTHER_INFO_IDEM included in conversion
* NUTS2021 codes are now included
* Country codes are now converted from 2-letter codes in TED XML to 3-letter codes from "Countries" codelist in eForms XML
* Namespace declarations are now harmonised across all XSLT files
The majority of changes included in this release are for the conversion of TED form F03, a Contract Award Notice. A new XSLT stylesheet, notice-result.xslt, has been created for this.

New mappings for "direct-award-justification", "non-award-justification" and "received-submission-type" have been added to other-mappings.xslt


## Minor changes

Minor fixes for:
* Buyer Legal Type (BT-11)
* Buyer Contracting Entity (BT-740)
* Electronic Auction (BT-767)
* PIN Competition Termination (BT-756)
8 changes: 5 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ The versioning scheme which will be adopted for the TED XML Data Converter will

Feedback on this converter is welcome. Please address questions, comments and bug reports using [Github Discussions](https://github.com/OP-TED/ted-xml-data-converter/discussions).

## Current status
All Contract Notice TED XML forms (F02, F05, F12, F21, F22, F23 and F24) are supported. See [usage-information.md](usage-information.md) for more details.

Work will begin on Contract Award notice forms in the near future.
## What's next?
All Contract Notice TED XML forms (F02, F05, F12, F21, F22, F23 and F24) are convertible.

The F03 Contract Award Notice form is convertible.

Work will begin on the remaining Contract Award notice forms (F06, F13, F15, F21, F22, F23, F24 and F25) in the near future.

11 changes: 11 additions & 0 deletions development-notices/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@ This table lists the TED XML files selected to test development of the Converter
| 353820_2021.xml | F02 | CN | | |
| 352444_2021.xml | F02 | CN | | |
| 352458_2021.xml | F02 | CN | | |
| 354625_2021.xml | F12 | CN | | |
| 354626_2021.xml | F12 | CN | | |
| 354823_2021.xml | F12 | CN | | |
| 352425_2021.xml | F03 | CAN | Contract award | PT_AWARD_CONTRACT_WITHOUT_CALL |
| 353237_2021.xml | F03 | CAN | Contract award | TERMINATION_PIN |
| 20-157399-001-EXP.xml | F03 | CAN | SettledContract | No DPS, no FRAMEWORK |
| 20-157543-001-EXP.xml | F03 | CAN | SettledContract | FRAMEWORK |
| 22-086633-001-EXP.xml | F03 | CAN | SettledContract | Multiple AWARD_CONTRACT collated into one SettledContract |
| 22-091559-001-EXP.xml | F03 | CAN | SettledContract | NO_AWARDED_CONTRACT |





68 changes: 17 additions & 51 deletions development-notices/eforms-xml/20-155018-001-EXP.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@
<efac:NoticeSubType>
<cbc:SubTypeCode listName="notice-subtype">4</cbc:SubTypeCode>
</efac:NoticeSubType>
<!-- efac:Organizations here -->
<!-- efac:Organizations -->
<efac:Organizations>
<efac:Organization><!--Organization Subrole (BT-770) : Group leader (Buyer)--><!--Organization Role : Acquiring CPB-->
<efac:Company><!--Organization Internet Address (BT-505)-->
<cbc:WebsiteURI>www.veitshoechheim.de</cbc:WebsiteURI>
<!--Winner Size (BT-165)-->
<!--Organization Technical Identifier (OPT-200)-->
<cac:PartyIdentification>
<cbc:ID schemeName="organization">ORG-0001</cbc:ID>
Expand Down Expand Up @@ -52,7 +53,7 @@
</efac:Company>
</efac:Organization>
</efac:Organizations>
<!-- efac:Publication here -->
<!-- efac:Publication -->
<efac:Publication><!--Notice Publication ID (OPP-010)-->
<efbc:NoticePublicationID schemeName="ojs-notice-id">12345678-2023</efbc:NoticePublicationID>
<!--OJEU Identifier (OPP-011)-->
Expand Down Expand Up @@ -84,21 +85,20 @@
<cbc:NoticeTypeCode listName="competition">cn-standard</cbc:NoticeTypeCode>
<!--Notice Official Language (BT-702) (first)-->
<cbc:NoticeLanguageCode>DEU</cbc:NoticeLanguageCode>
<!-- cac:ContractingParty here -->
<cac:ContractingParty><!--Buyer Profile URL (BT-508)--><!--Buyer Legal Type (BT-11) and Buyer Contracting Entity (BT-740)--><!--Buyer Legal Type (BT-11)-->
<!-- cac:ContractingParty -->
<cac:ContractingParty><!--Buyer Profile URL (BT-508)--><!--Buyer Legal Type (BT-11)-->
<cac:ContractingPartyType>
<cbc:PartyTypeCode listName="buyer-legal-type">ra</cbc:PartyTypeCode>
</cac:ContractingPartyType>
<!--Buyer Contracting Entity (BT-740)-->
<!--WARNING: "Buyer contracting type" codelist not yet available. Value "not-cont-ent" used as a default-->
<cac:ContractingPartyType>
<cbc:PartyTypeCode listName="buyer-contracting-type">not-cont-ent</cbc:PartyTypeCode>
</cac:ContractingPartyType>
<!--Activity Authority (BT-10) and Activity Entity (BT-610)-->
<!--Activity Authority (BT-10)-->
<cac:ContractingActivity>
<cbc:ActivityTypeCode listName="authority-activity">gen-pub</cbc:ActivityTypeCode>
</cac:ContractingActivity>
<!--Activity Entity (BT-610)-->
<cac:Party><!--Buyer Technical Identifier Reference (OPT-300)-->
<cac:PartyIdentification>
<cbc:ID schemeName="organization">ORG-0001</cbc:ID>
Expand All @@ -112,9 +112,9 @@
<!--Reference (Technical ID) to the legal organization acting as a Buyer.-->
</cac:Party>
</cac:ContractingParty>
<!-- cac:TenderingTerms here -->
<!-- cac:TenderingTerms -->
<cac:TenderingTerms><!--Cross Border Law (BT-09)--><!--BT-01 Legal Basis Local - Text--><!--Exclusion Grounds (BT-67)--><!--Lots Max Awarded (BT-33)--><!--Lots Max Allowed (BT-31)--><!--Group Identifier (BT-330)--><!--Group Lot Identifier (BT-1375)--></cac:TenderingTerms>
<!-- cac:TenderingProcess here -->
<!-- cac:TenderingProcess -->
<cac:TenderingProcess>
<ext:UBLExtensions>
<ext:UBLExtension>
Expand All @@ -133,7 +133,7 @@
<!--Direct Award Justification (BT-136)-->
<!--Direct Award Justification (BT-135)-->
</cac:TenderingProcess>
<!-- cac:ProcurementProject here -->
<!-- cac:ProcurementProject -->
<cac:ProcurementProject><!--Internal Identifier (BT-22)--><!--Title (BT-21)-->
<cbc:Name languageID="DEU">Gemeinde Veitshöchheim, Sportplatzbauarbeiten an der Freisportanlage</cbc:Name>
<!--Description (BT-24)-->
Expand All @@ -155,44 +155,12 @@
<!--Place Performance Street (BT-5101)-->
<!--Place Performance Country Code (BT-5141)-->
</cac:ProcurementProject>
<!-- multiple cac:ProcurementProjectLot here -->
<cac:ProcurementProjectLot><!--Only one Lot in the TED notice-->
<cbc:ID schemeName="Lot">LOT-0001</cbc:ID>
<!-- Lot cac:TenderingTerms here -->
<cac:TenderingTerms>
<ext:UBLExtensions>
<ext:UBLExtension>
<ext:ExtensionContent>
<efext:EformsExtension><!--Selection Criteria Second Stage Invite (BT-40)--><!--Selection Criteria Second Stage Invite Number Weight (BT-7531)--><!--Selection Criteria Second Stage Invite Number Threshold (BT-7532)--><!--Selection Criteria Second Stage Invite Number (BT-752)--></efext:EformsExtension>
</ext:ExtensionContent>
</ext:UBLExtension>
</ext:UBLExtensions>
<!--Variants (BT-63)-->
<!--EU Funds (BT-60)-->
<!--Performing Staff Qualification (BT-79)-->
<!--Recurrence (BT-94)-->
<!--Recurrence Description (BT-95)-->
<!--Security Clearance Deadline (BT-78)-->
<!--Multiple Tenders (BT-769)-->
<!--Documents Restricted Justification (BT-707)-->
<!--Documents Official Language (BT-708)-->
<!--Documents Unofficial Language (BT-737)-->
<!--Terms Financial (BT-77)-->
<!--Reserved Participation (BT-71)-->
<!--Reserved Participation (BT-71)-->
<!--Tenderer Legal Form (BT-761)-->
<!--Tenderer Legal Form Description (BT-76)-->
<!--Late Tenderer Information (BT-771)-->
<!--Subcontracting Tender Indication (BT-651)-->
<!--Subcontracting Obligation (BT-65)-->
<!--Subcontracting Obligation Maximum (BT-729)-->
<!--Subcontracting Obligation Minimum (BT-64)-->
<!--Reserved Execution (BT-736)-->
<!--Electronic Invoicing (BT-743)-->
<!--Terms Performance (BT-70)-->
<!--Submission Electronic Catalog (BT-764)-->
<!--Submission Electronic Signature (BT-744)-->
<cac:AwardingTerms><!--Following Contract (BT-41)--><!--Jury Decision Binding (BT-42)--><!--No Negotiation Necessary (BT-120)--><!--*** start of cac:AwardingCriterion ***--><!--Award Criteria Order Justification (BT-733)--><!--Award Criteria Complicated (BT-543)--><!--Award Criterion Number Weight (BT-5421)--><!--Award Criterion Number Fixed (BT-5422)--><!--Award Criterion Number Threshold (BT-5423)--><!--Award Criterion Number (BT-541)--><!--Award Criterion Type (BT-539)--><!--Award Criterion Name (BT-734)--><!--Award Criterion Description (BT-540)--><!--*** end of cac:AwardingCriterion ***--><!--Jury Member Name (BT-46)--><!--Prize information (Prize Rank (BT-44), Rewards Other (BT-45), Value Prize (BT-644))--></cac:AwardingTerms>
<!-- multiple cac:ProcurementProjectLot -->
<cac:ProcurementProjectLot><!--Purpose Lot Identifier (BT-137)--><!--Only one Lot in the TED notice-->
<cbc:ID schemeName="Lot">LOT-0000</cbc:ID>
<!-- Lot cac:TenderingTerms -->
<cac:TenderingTerms><!--Selection Criteria Type (BT-747)--><!--Selection Criteria Name (BT-749)--><!--Selection Criteria Description (BT-750)--><!--Selection Criteria Used (BT-748)--><!--Selection Criteria Second Stage Invite (BT-40)--><!--Selection Criteria Second Stage Invite Number Weight (BT-7531)--><!--Selection Criteria Second Stage Invite Number Threshold (BT-7532)--><!--Selection Criteria Second Stage Invite Number (BT-752)--><!--Variants (BT-63)--><!--EU Funds (BT-60)--><!--Performing Staff Qualification (BT-79)--><!--Recurrence (BT-94)--><!--Recurrence Description (BT-95)--><!--Security Clearance Deadline (BT-78)--><!--Multiple Tenders (BT-769)--><!--Documents Restricted Justification (BT-707)--><!--Documents Official Language (BT-708)--><!--Documents Unofficial Language (BT-737)--><!--Terms Financial (BT-77)--><!--Reserved Participation (BT-71)--><!--Reserved Participation (BT-71)--><!--Tenderer Legal Form (BT-761)--><!--Tenderer Legal Form Description (BT-76)--><!--Late Tenderer Information (BT-771)--><!--Subcontracting Tender Indication (BT-651)--><!--Subcontracting Obligation (BT-65)--><!--Subcontracting Obligation Maximum (BT-729)--><!--Subcontracting Obligation Minimum (BT-64)--><!--Reserved Execution (BT-736)--><!--Electronic Invoicing (BT-743)--><!--Terms Performance (BT-70)--><!--Submission Electronic Catalog (BT-764)--><!--Submission Electronic Signature (BT-744)-->
<cac:AwardingTerms><!--Following Contract (BT-41)--><!--Jury Decision Binding (BT-42)--><!--No Negotiation Necessary (BT-120)--><!--Award Criteria Order Justification (BT-733)--><!--Award Criteria Complicated (BT-543)--><!--Award Criterion Number Weight (BT-5421)--><!--Award Criterion Number Fixed (BT-5422)--><!--Award Criterion Number Threshold (BT-5423)--><!--Award Criterion Number (BT-541)--><!--Award Criterion Type (BT-539)--><!--Award Criterion Name (BT-734)--><!--Award Criterion Description (BT-540)--><!--Jury Member Name (BT-46)--><!--Prize information (Prize Rank (BT-44), Rewards Other (BT-45), Value Prize (BT-644))--></cac:AwardingTerms>
<cac:AdditionalInformationParty>
<cac:PartyIdentification>
<cbc:ID schemeName="organization">ORG-0001</cbc:ID>
Expand All @@ -201,18 +169,16 @@
<!--Submission URL (BT-18)-->
<!--Tender Validity Deadline (BT-98)-->
<!--Review Deadline Description (BT-99)-->
<!--*** start of cac:AppealTerms ***-->
<!--cac:PresentationPeriod: Review Deadline Description (BT-99)-->
<!--cac:AppealInformationParty: Review Information Providing Organization-->
<!--cac:AppealReceiverParty: Review organization-->
<!--cac:MediationParty: Mediation organization-->
<!--*** end of cac:AppealTerms ***-->
<!--Submission Language (BT-97)-->
<!--Participant Name (BT-47)-->
<!--Security Clearance Code (BT-578)-->
<!--Security Clearance Description (BT-732)-->
</cac:TenderingTerms>
<!-- cac:TenderingProcess here -->
<!-- cac:TenderingProcess -->
<cac:TenderingProcess>
<ext:UBLExtensions>
<ext:UBLExtension>
Expand Down Expand Up @@ -249,7 +215,7 @@
<!--Framework Agreement (BT-765)-->
<!--Dynamic Purchasing System (BT-766)-->
</cac:TenderingProcess>
<!-- cac:ProcurementProject here -->
<!-- cac:ProcurementProject -->
<cac:ProcurementProject><!--Internal Identifier (BT-22)--><!--WARNING: Internal ID (BT-22) is required but there is no equivalent element in TED XML.-->
<cbc:ID schemeName="InternalID"/>
<!--Title (BT-21)-->
Expand Down
Loading