Feature/ted 174 #56
Merged
Feature/ted 174 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 98.73% 98.76% +0.02%
==========================================
Files 44 45 +1
Lines 1659 1699 +40
==========================================
+ Hits 1638 1678 +40
Misses 21 21
Continue to review full report at Codecov.
|
costezki
approved these changes
Apr 12, 2022
| field_xpath = row[RULES_FIELD_XPATH] | ||
| class_path = row[RULES_CLASS_PATH] | ||
| property_path = row[RULES_PROPERTY_PATH] | ||
| yield f"#title: {sf_field_id} - {sf_field_name}\n" \ |
There was a problem hiding this comment.
Ouch! Should we not use at least a Jina template here?
|
|
||
| def mapping_suite_processor_generate_sparql_queries(mapping_suite_package_path: pathlib.Path): | ||
| """ | ||
| This function reads data from conceptual_mappings.xlsx and generates SPARQL validation queries in provided package. |
There was a problem hiding this comment.
I like the documentation.
|
|
||
|
|
||
|
|
||
| class temporary_copy(object): |
There was a problem hiding this comment.
This need is odd to me. I am curious about where you use it.
It is, however, elegant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.