Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ted 25 #51

Merged
merged 62 commits into from
Apr 6, 2022
Merged

Feature/ted 25 #51

merged 62 commits into from
Apr 6, 2022

Conversation

CaptainOfHacks
Copy link
Contributor

No description provided.

@CaptainOfHacks
add dags
3f7fa50
@CaptainOfHacks
Update notice_fetcher_master.py
7b0a41c
@CaptainOfHacks
Update pipeline_scheduler.py
8d9259f
@CaptainOfHacks
Merge remote-tracking branch 'origin/feature/TED-90' into feature/TED-25
eda9e0f
@CaptainOfHacks
WIP
a1ea395
@CaptainOfHacks
WIP
9ef0db6
@CaptainOfHacks
Merge branch 'main' into feature/TED-25
e0427eb
@CaptainOfHacks
Update .gitignore
8772533
@CaptainOfHacks
Merge branch 'main' into feature/TED-25
e6a1398
@CaptainOfHacks
Merge branch 'main' into feature/TED-25
aaea2cc
@CaptainOfHacks
Merge branch 'main' into feature/TED-25
156df3e
@CaptainOfHacks
Update notice_transformer.py
7632fc0
@CaptainOfHacks
Merge branch 'main' into feature/TED-25
b82f25c
@CaptainOfHacks
wip
fe0bd32
@CaptainOfHacks
WIP
6040db0
@CaptainOfHacks
Update single_notice_processing_pipeline_with_decorators.py
bb7e5cb
@CaptainOfHacks
Update single_notice_processing_pipeline_with_decorators.py
486f7cb
@CaptainOfHacks
Update docker-compose.yaml
72f19b6
@CaptainOfHacks
Merge branch 'main' into feature/TED-25
d723cd4
@CaptainOfHacks
Create selector_daily_fetch_orchestrator.py
e7a172b
@CaptainOfHacks
Create selector_repackage_process_orchestrator.py
54c78fe
@CaptainOfHacks
Create selector_republish_process_orchestrator.py
2ffc1ad
@CaptainOfHacks
Create selector_retransform_process_orchestrator.py
574ce68
@CaptainOfHacks
Create worker_single_notice_process_orchestrator.py
48f9f62
@CaptainOfHacks
Delete single_notice_processing_pipeline_with_decorators.py
7900e8c
@CaptainOfHacks
Update selector_daily_fetch_orchestrator.py
530ed12
@CaptainOfHacks
Update selector_retransform_process_orchestrator.py
80eaeb2
@CaptainOfHacks
Merge branch 'main' into feature/TED-25
186cd95
@CaptainOfHacks
Update selector_retransform_process_orchestrator.py
9718898
@CaptainOfHacks
Update worker_single_notice_process_orchestrator.py
0effcc9
costezki
costezki requested changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Let's have those comments addressed and the tests passion on the server.

dags/selector_daily_fetch_orchestrator.py Outdated Show resolved Hide resolved
dags/selector_repackage_process_orchestrator.py Show resolved Hide resolved
dags/selector_repackage_process_orchestrator.py Show resolved Hide resolved
dags/selector_republish_process_orchestrator.py Outdated Show resolved Hide resolved
dags/selector_retransform_process_orchestrator.py Outdated Show resolved Hide resolved
ted_sws/core/model/metadata.py Show resolved Hide resolved
ted_sws/core/model/notice.py Show resolved Hide resolved
ted_sws/data_manager/adapters/notice_repository.py Show resolved Hide resolved
ted_sws/metadata_normaliser/services/metadata_normalizer.py Show resolved Hide resolved
ted_sws/metadata_normaliser/services/metadata_normalizer.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #51 (8b66124) into main (cf1efc5) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8b66124 differs from pull request most recent head eedb0e7. Consider uploading reports for the commit eedb0e7 to get more accurate results

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   98.58%   98.60%   +0.01%     
==========================================
  Files          42       42              
  Lines        1554     1576      +22     
==========================================
+ Hits         1532     1554      +22     
  Misses         22       22
Impacted Files Coverage Δ
ted_sws/__init__.py 89.47% <0.00%> (ø)
ted_sws/data_manager/adapters/notice_repository.py 100.00% <0.00%> (ø)
...r/services/xml_manifestation_metadata_extractor.py 98.71% <0.00%> (+0.01%) ⬆️
.../notice_eligibility/services/notice_eligibility.py 97.22% <0.00%> (+0.07%) ⬆️
ted_sws/core/model/notice.py 98.74% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a913d...eedb0e7. Read the comment docs.

@CaptainOfHacks CaptainOfHacks merged commit 78a6092 into main Apr 6, 2022
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-25 branch April 6, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costezki costezki costezki approved these changes

@Dragos0000 Dragos0000 Awaiting requested review from Dragos0000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CaptainOfHacks @costezki @Dragos0000