-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ted 1219 packages #447
Conversation
✅ Linked to Task TED-1219 · Update the METS test packages generator |
def validate_notice_action_type(v): | ||
if v not in ACCEPTED_ACTIONS: | ||
raise ValueError('No such action: %s' % v) | ||
def validate_mets_type(v): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is v ? victory ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it’s a short name for value when used in a very small context (likke: k => v: key => value)
|
||
@validator('type') | ||
def validate_notice_action_type(cls, v): | ||
validate_mets_type(v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is v ? vicar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tell us more about v
Codecov ReportBase: 96.23% // Head: 96.33% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 96.23% 96.33% +0.09%
==========================================
Files 106 106
Lines 5531 5586 +55
==========================================
+ Hits 5323 5381 +58
+ Misses 208 205 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
No description provided.