Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ted 1219 packages #447

Merged
merged 5 commits into from
Feb 20, 2023
Merged

Feature/ted 1219 packages #447

merged 5 commits into from
Feb 20, 2023

Conversation

kaleanych
Copy link
Contributor

No description provided.

@swarmia
Copy link

swarmia bot commented Feb 17, 2023

✅  Linked to Task TED-1219 · Update the METS test packages generator

def validate_notice_action_type(v):
if v not in ACCEPTED_ACTIONS:
raise ValueError('No such action: %s' % v)
def validate_mets_type(v):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is v ? victory ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it’s a short name for value when used in a very small context (likke: k => v: key => value)


@validator('type')
def validate_notice_action_type(cls, v):
validate_mets_type(v)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is v ? vicar?

Copy link
Collaborator

@Dragos0000 Dragos0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tell us more about v

@codecov-commenter
Copy link

Codecov Report

Base: 96.23% // Head: 96.33% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (52e2a55) compared to base (09f4d28).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   96.23%   96.33%   +0.09%     
==========================================
  Files         106      106              
  Lines        5531     5586      +55     
==========================================
+ Hits         5323     5381      +58     
+ Misses        208      205       -3     
Impacted Files Coverage Δ
...sws/notice_packager/adapters/template_generator.py 100.00% <100.00%> (ø)
ted_sws/notice_packager/model/metadata.py 100.00% <100.00%> (ø)
...s/notice_packager/services/metadata_transformer.py 100.00% <100.00%> (+1.92%) ⬆️
...ed_sws/notice_packager/services/notice_packager.py 100.00% <100.00%> (+2.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaleanych kaleanych merged commit 4b345f9 into main Feb 20, 2023
@kaleanych kaleanych deleted the feature/TED-1219-packages branch February 20, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants