Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env_property for minimize inspect stack calls #353

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

CaptainOfHacks
Copy link
Contributor

No description provided.

@swarmia
Copy link

swarmia bot commented Nov 10, 2022

✅  Linked to Bug TED-943 · Resolve lazy imports in Airflow

@codecov-commenter
Copy link

Codecov Report

Base: 99.05% // Head: 99.02% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (7e7957d) compared to base (33cc7e6).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7e7957d differs from pull request most recent head 53acce4. Consider uploading reports for the commit 53acce4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   99.05%   99.02%   -0.04%     
==========================================
  Files         123      123              
  Lines        6143     6152       +9     
==========================================
+ Hits         6085     6092       +7     
- Misses         58       60       +2     
Impacted Files Coverage Δ
ted_sws/core/adapters/config_resolver.py 75.47% <100.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Awesome!

@@ -38,174 +38,168 @@

class MongoDBConfig:

@property
def MONGO_DB_AUTH_URL(self) -> str:
@env_property()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env == envious property?

Who is it envious on?

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@CaptainOfHacks CaptainOfHacks merged commit 1bb31dd into main Nov 10, 2022
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-943 branch November 10, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants