Feature/ted 823

ted_sws/notice_validator/adapters/validation_summary_runner.py

@@ -147,10 +147,11 @@ def validation_summary(self) -> XMLManifestationValidationSummaryReport:
         report: XMLManifestationValidationSummaryReport = XMLManifestationValidationSummaryReport()
         xpath_coverage_summary: XPATHCoverageSummaryReport = report.xpath_coverage_summary
 
-        xml_manifestation = notices[0].xml_manifestation
-        if xml_manifestation.xpath_coverage_validation:
-            mapping_suite_identifier = xml_manifestation.xpath_coverage_validation.mapping_suite_identifier
-            xpath_coverage_summary.mapping_suite_identifier = mapping_suite_identifier
+        if len(notices) > 0:
+            xml_manifestation = notices[0].xml_manifestation
+            if xml_manifestation.xpath_coverage_validation:
+                mapping_suite_identifier = xml_manifestation.xpath_coverage_validation.mapping_suite_identifier
+                xpath_coverage_summary.mapping_suite_identifier = mapping_suite_identifier
 
         validation_result: XPATHCoverageSummaryResult = report.xpath_coverage_summary.validation_result
         for notice in notices:

tests/e2e/supra_notice_manager/conftest.py

@@ -0,0 +1,19 @@
+import pytest
+import mongomock
+import pymongo
+
+from ted_sws.data_manager.adapters.supra_notice_repository import DailySupraNoticeRepository
+
+
+@pytest.fixture
+@mongomock.patch(servers=(('server.example.com', 27017),))
+def mongodb_client():
+    mongo_client = pymongo.MongoClient('server.example.com')
+    for database_name in mongo_client.list_database_names():
+        mongo_client.drop_database(database_name)
+    return mongo_client
+
+
+@pytest.fixture
+def daily_supra_notice_repository(mongodb_client) -> DailySupraNoticeRepository:
+    return DailySupraNoticeRepository(mongodb_client=mongodb_client)

tests/e2e/supra_notice_manager/test_supra_notice_validator.py

@@ -0,0 +1,21 @@
+from datetime import datetime, time
+
+import pytest
+
+from ted_sws.supra_notice_manager.services.daily_supra_notice_manager import \
+    create_and_store_in_mongo_db_daily_supra_notice
+from ted_sws.supra_notice_manager.services.supra_notice_validator import validate_and_update_daily_supra_notice
+
+
+def test_supra_notice_validator(mongodb_client, daily_supra_notice_repository):
+    today = datetime.combine(datetime.today(), time())
+
+    notice_ids = ["XYZ067623-2022023"]
+    create_and_store_in_mongo_db_daily_supra_notice(notice_ids=notice_ids, mongodb_client=mongodb_client,
+                                                    notice_fetched_date=today)
+    validate_and_update_daily_supra_notice(today, mongodb_client)
+    result = daily_supra_notice_repository.get(reference=today)
+    assert result
+    assert len(result.validation_report.missing_notice_ids) > 0
+    assert notice_ids[0] not in result.validation_report.missing_notice_ids
+    assert not result.validation_report.is_valid()

tests/unit/notice_validator/test_validation_summary_runner.py

@@ -1,6 +1,7 @@
 import pytest
 
-from ted_sws.notice_validator.services.validation_summary_runner import validation_summary_report_notice_by_id
+from ted_sws.notice_validator.services.validation_summary_runner import validation_summary_report_notice_by_id, \
+    generate_validation_summary_report_notices
 from ted_sws.data_manager.adapters.notice_repository import NoticeRepository
 
 
@@ -18,3 +19,12 @@ def test_validation_summary_runner(fake_validation_notice, mongodb_client):
     assert notice.validation_summary.xml_manifestation
     assert notice.validation_summary.rdf_manifestation
     assert notice.validation_summary.distilled_rdf_manifestation
+
+
+def test_generate_validation_summary_report_notices(fake_validation_notice):
+    report = generate_validation_summary_report_notices([fake_validation_notice])
+    assert report
+    assert report.notice_id == [fake_validation_notice.ted_id]
+    assert report.xml_manifestation.xpath_coverage_summary.mapping_suite_identifier == fake_validation_notice.xml_manifestation.xpath_coverage_validation.mapping_suite_identifier
+    assert report.rdf_manifestation
+    assert report.distilled_rdf_manifestation

tests/unit/supra_notice_manager/test_supra_notice_validator.py

@@ -18,7 +18,8 @@ def test_supra_notice_validator(mongodb_client, daily_supra_notice_repository, f
     api_document_id = "067623-2022"
 
     notice_ids = ["1", "2", "3"]
-    create_and_store_in_mongo_db_daily_supra_notice(notice_ids=notice_ids, mongodb_client=mongodb_client)
+    create_and_store_in_mongo_db_daily_supra_notice(notice_ids=notice_ids, mongodb_client=mongodb_client,
+                                                    notice_fetched_date=today)
     validate_and_update_daily_supra_notice(today, mongodb_client, fake_request_api)
     result = daily_supra_notice_repository.get(reference=today)
     assert result