Feature/ted 713 #293

kaleanych · 2022-10-05T01:22:16Z

No description provided.

swarmia · 2022-10-05T01:22:19Z

✅ Linked to Story TED-713 · Mapping suite diff

codecov-commenter · 2022-10-05T01:33:57Z

Codecov Report

Base: 98.85% // Head: 98.99% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (9ab02ca) compared to base (41c53c5).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9ab02ca differs from pull request most recent head 1ff96cc. Consider uploading reports for the commit 1ff96cc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   98.85%   98.99%   +0.14%     
==========================================
  Files         103      106       +3     
  Lines        5233     5486     +253     
==========================================
+ Hits         5173     5431     +258     
+ Misses         60       55       -5

Impacted Files	Coverage Δ
...ed_sws/data_sampler/services/notice_xml_indexer.py	`98.16% <ø> (-1.84%)`	⬇️
ted_sws/core/adapters/cmd_runner.py	`100.00% <100.00%> (ø)`
ted_sws/core/model/transform.py	`100.00% <100.00%> (ø)`
.../data_manager/adapters/mapping_suite_repository.py	`100.00% <100.00%> (ø)`
...apping_suite_processor/entrypoints/cli/__init__.py	`100.00% <100.00%> (ø)`
...r/entrypoints/cli/cmd_conceptual_mapping_differ.py	`100.00% <100.00%> (ø)`
...sor/entrypoints/cli/cmd_mapping_suite_validator.py	`100.00% <100.00%> (ø)`
..._sws/mapping_suite_processor/resources/__init__.py	`100.00% <100.00%> (ø)`
...te_processor/services/conceptual_mapping_differ.py	`100.00% <100.00%> (ø)`
...sor/services/conceptual_mapping_files_injection.py	`100.00% <100.00%> (ø)`
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

CaptainOfHacks · 2022-10-05T11:21:25Z

ted_sws/core/adapters/cmd_runner.py

@@ -63,6 +63,29 @@ def __init__(self, name=__name__, logger: EventLogger = None):

        self.logger = logger

+    @classmethod
+    def _init_list_input_opts_split(cls, input_val) -> List:


use typing for input_val

CaptainOfHacks · 2022-10-05T11:25:12Z

ted_sws/notice_validator/entrypoints/cli/cmd_sparql_runner.py

@@ -46,6 +46,8 @@ def __init__(
        repository_path = Path(self.mappings_path)
        mapping_suite_repository = MappingSuiteRepositoryInFileSystem(repository_path=repository_path)
        self.mapping_suite = mapping_suite_repository.get(reference=self.mapping_suite_id)
+        self.log("K :: " + str(repository_path))
