Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create notice selector by status #26

Merged
merged 1 commit into from
Mar 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ted_sws/data_manager/adapters/notice_repository.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import Iterator
from pymongo import MongoClient
from ted_sws.domain.adapters.repository_abc import NoticeRepositoryABC
from ted_sws.domain.model.notice import Notice
from ted_sws.domain.model.notice import Notice, NoticeStatus


class NoticeRepository(NoticeRepositoryABC):
Expand Down Expand Up @@ -35,7 +35,7 @@ def update(self, notice: Notice):
"""
notice_dict = notice.dict()
notice_dict["_id"] = notice_dict["ted_id"]
self.collection.update_one({'_id':notice_dict["_id"]}, {"$set": notice_dict})
self.collection.update_one({'_id': notice_dict["_id"]}, {"$set": notice_dict})

def get(self, reference) -> Notice:
"""
Expand All @@ -46,6 +46,15 @@ def get(self, reference) -> Notice:
result_dict = self.collection.find_one({"ted_id": reference})
return Notice(**result_dict) if result_dict else None

def get_notice_by_status(self, notice_status: NoticeStatus) -> Iterator[Notice]:
"""
This method provides all notices based on its status.
:param notice_status:
:return:
"""
for result_dict in self.collection.find({"status": notice_status}):
yield Notice(**result_dict)

def list(self) -> Iterator[Notice]:
"""
This method allows all records to be retrieved from the repository.
Expand Down
10 changes: 9 additions & 1 deletion ted_sws/domain/adapters/repository_abc.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import abc
from typing import Iterator

from ted_sws.domain.model.notice import Notice
from ted_sws.domain.model.notice import Notice, NoticeStatus


class RepositoryABC(abc.ABC):
Expand Down Expand Up @@ -39,6 +39,14 @@ def get(self, reference) -> Notice:
:return: Notice
"""

@abc.abstractmethod
def get_notice_by_status(self, notice_status: NoticeStatus) -> Iterator[Notice]:
"""
This method provides all notices based on its status.
:param notice_status:
:return:
"""

@abc.abstractmethod
def list(self) -> Iterator[Notice]:
"""
Expand Down
10 changes: 9 additions & 1 deletion tests/fakes/fake_repository.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import Iterator

from ted_sws.domain.adapters.repository_abc import NoticeRepositoryABC
from ted_sws.domain.model.notice import Notice
from ted_sws.domain.model.notice import Notice, NoticeStatus


class FakeNoticeRepository(NoticeRepositoryABC):
Expand Down Expand Up @@ -42,6 +42,14 @@ def get(self, reference) -> Notice:

return None

def get_notice_by_status(self, notice_status: NoticeStatus) -> Iterator[Notice]:
"""
This method provides all notices based on its status.
:param notice_status:
:return:
"""
return [value for value in self.repository.values() if value.status == notice_status]

def list(self) -> Iterator[Notice]:
"""
This method allows all records to be retrieved from the repository.
Expand Down
14 changes: 13 additions & 1 deletion tests/unit/data_manager/test_notice_repository.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from ted_sws.data_manager.adapters.notice_repository import NoticeRepository
from ted_sws.domain.model.manifestation import XMLManifestation
from ted_sws.domain.model.metadata import TEDMetadata
from ted_sws.domain.model.notice import Notice
from ted_sws.domain.model.notice import Notice, NoticeStatus

NOTICE_TED_ID = "123456"
TEST_DB_NAME = 'test_db'
Expand Down Expand Up @@ -31,3 +31,15 @@ def test_notice_repository_create(mongodb_client):
assert result_notice.ted_id == NOTICE_TED_ID
assert result_notice.original_metadata.AA == "Updated metadata"
mongodb_client.drop_database(TEST_DB_NAME)


def test_notice_repository_get_notice_by_status(mongodb_client):
mongodb_client.drop_database(TEST_DB_NAME)
notice_repository = NoticeRepository(mongodb_client=mongodb_client, database_name=TEST_DB_NAME)
notice = Notice(ted_id=NOTICE_TED_ID, original_metadata=TEDMetadata(**{"AA": "Metadata"}),
xml_manifestation=XMLManifestation(object_data="HELLO"))
notice_repository.add(notice)
result_notices = notice_repository.get_notice_by_status(notice_status=NoticeStatus.RAW)
for result_notice in result_notices:
assert result_notice.status == NoticeStatus.RAW