Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ted 635 #219

Merged
merged 28 commits into from
Sep 1, 2022
Merged

Feature/ted 635 #219

merged 28 commits into from
Sep 1, 2022

Conversation

Mihai10Mihai
Copy link
Contributor

No description provided.

Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those tests are unit tests, not e2e.

Copy link
Contributor

@CaptainOfHacks CaptainOfHacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise tests, some of them failing.

@kaleanych kaleanych requested review from CaptainOfHacks and removed request for CaptainOfHacks August 31, 2022 15:42
@codecov-commenter
Copy link

Codecov Report

Merging #219 (e1ff21a) into main (51b9cf8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   98.70%   98.68%   -0.03%     
==========================================
  Files         115      111       -4     
  Lines        5030     5084      +54     
==========================================
+ Hits         4965     5017      +52     
- Misses         65       67       +2     
Impacted Files Coverage Δ
...ices/conceptual_mapping_generate_sparql_queries.py 100.00% <ø> (ø)
.../notice_transformer/services/notice_transformer.py 100.00% <ø> (ø)
ted_sws/__init__.py 92.91% <100.00%> (+0.23%) ⬆️
ted_sws/core/adapters/cmd_runner.py 100.00% <100.00%> (ø)
ted_sws/core/model/manifestation.py 100.00% <100.00%> (ø)
ted_sws/core/model/supra_notice.py 100.00% <100.00%> (ø)
ted_sws/core/model/transform.py 100.00% <100.00%> (ø)
.../data_manager/adapters/mapping_suite_repository.py 100.00% <100.00%> (ø)
ted_sws/data_manager/adapters/notice_repository.py 96.96% <100.00%> (+0.01%) ⬆️
ted_sws/data_manager/adapters/sparql_endpoint.py 96.55% <100.00%> (-2.26%) ⬇️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@CaptainOfHacks CaptainOfHacks merged commit a927253 into main Sep 1, 2022
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-635 branch September 1, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants