Prevent empty data from rendering move page modal. #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiwel
force-pushed
the
bug-adding-question-page
branch
from
e9126bc to
4edaac3
Compare
SamGodwin2
force-pushed
the
bug-adding-question-page
branch
from
4edaac3 to
f79e8d5
Compare
SamGodwin2
force-pushed
the
bug-adding-question-page
branch
from
18787da to
f90156f
Compare
SamGodwin2
approved these changes
Aug 2, 2019
SamGodwin2
force-pushed
the
bug-adding-question-page
branch
6 times, most recently
from
4c6de03 to
bc0dacf
Compare
pricea1
suggested changes
Aug 5, 2019
SamGodwin2
force-pushed
the
bug-adding-question-page
branch
2 times, most recently
from
a3ad397 to
464bf92
Compare
SamGodwin2
force-pushed
the
bug-adding-question-page
branch
2 times, most recently
from
051b144 to
4f0faf9
Compare
SamGodwin2
force-pushed
the
bug-adding-question-page
branch
from
4f0faf9 to
491b5b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
There seems to be an issue where sometimes, possibly when a value is both simultaneously being mutated and queried from the cache, where a Query component will return an empty data object, even though the query has finished loading and there are no errors.
This was causing our application to crash because the modal assumes that it is being passed a valid data object, based on assumptions being made in the PropTypes.
This is a known issue and this fix uses refetchPartial which according to the docs this is fine however we may have to keep an eye on this issue as it moves along apollographql/react-apollo/issues/2114
How to review