Skip to content

Commit

Permalink
wip: fixing code coverage
Browse files Browse the repository at this point in the history 
Refs: BLAIS5-4525
  • Loading branch information
@SidraJaved
SidraJaved committed Dec 30, 2024
1 parent 1d23157 commit dc309d9
Showing 1 changed file with 126 additions and 115 deletions.
241 changes: 126 additions & 115 deletions src/api/http/users.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ import { cleanup } from "@testing-library/react";
import { mock_server_request_function, mock_server_request_Return_JSON } from "../../tests/utils";
import { addNewUser, deleteUser, editPassword, getAllUsers } from "./users";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import deleteUser.
import { NewUser, User } from "blaise-api-node-client";
import { requestPromiseJson, requestPromiseJsonList } from "./requestPromise";

jest.mock('./requestPromise');

Check failure on line 11 in src/api/http/users.test.ts

View workflow job for this annotation

GitHub Actions / lint (20.x) 

Strings must use doublequote

const requestPromiseJsonMock = requestPromiseJson as jest.Mock<Promise<[number, JSON]>>;

const userList: User[] = [
{ defaultServerPark: "gusty", name: "TestUser123", role: "DST", serverParks: ["gusty"] },
Expand All @@ -15,48 +20,56 @@ const userList: User[] = [
describe("Function getAllUsers(filename: string) ", () => {

it("It should return true with data if the list is returned successfully", async () => {
mock_server_request_Return_JSON(200, userList);
(requestPromiseJsonList as jest.Mock).mockResolvedValue([true, userList]);

const [success, users] = await getAllUsers();
expect(success).toBeTruthy();
expect(users).toEqual(userList);
});

it("It should return true with an empty list if a 404 is returned from the server", async () => {
mock_server_request_Return_JSON(404, []);
(requestPromiseJsonList as jest.Mock).mockResolvedValue([true, []]);
const [success, users] = await getAllUsers();
expect(success).toBeTruthy();
expect(users).toEqual([]);
});

it("It should return false with an empty list if request returns an error code", async () => {
mock_server_request_Return_JSON(500, {});
(requestPromiseJsonList as jest.Mock).mockResolvedValue([false, []]);
const [success, users] = await getAllUsers();
expect(success).toBeFalsy();
expect(users).toEqual([]);
});

it("It should return false with an empty list if request JSON is not a list", async () => {
mock_server_request_function(jest.fn(() => Promise.resolve({
status: 400,
json: () => Promise.reject("Failed")
})));
// mock_server_request_function(jest.fn(() => Promise.resolve({
// status: 400,
// json: () => Promise.reject("Failed")
// })));
// let promiseResponse: [number, JSON];
// promiseResponse = [400, JSON.parse(() => Promise.reject("Failed"))];
requestPromiseJsonMock.mockRejectedValue(new Error('Async error'));

Check failure on line 51 in src/api/http/users.test.ts

View workflow job for this annotation

GitHub Actions / lint (20.x) 

Strings must use doublequote

const [success, users] = await getAllUsers();
expect(success).toBeFalsy();
expect(users).toEqual([]);
});

it("It should return false with an empty list if request JSON is invalid", async () => {
mock_server_request_Return_JSON(200, { name: "NAME" });

let promiseResponse: [number, JSON];
promiseResponse = [200, JSON.parse(JSON.stringify({ name: "NAME" }))]

Check failure on line 61 in src/api/http/users.test.ts

View workflow job for this annotation

GitHub Actions / lint (20.x) 

'promiseResponse' is never reassigned. Use 'const' instead

Check failure on line 61 in src/api/http/users.test.ts

View workflow job for this annotation

GitHub Actions / lint (20.x) 

Missing semicolon
requestPromiseJsonMock.mockResolvedValue(promiseResponse);
const [success, users] = await getAllUsers();
expect(success).toBeFalsy();
expect(users).toEqual([]);
});

it("It should return false with an empty list if request call fails", async () => {
mock_server_request_function(jest.fn(() => {
throw new Error("Network error");
}));
// mock_server_request_function(jest.fn(() => {
// throw new Error("Network error");
// }));
requestPromiseJsonMock.mockImplementation(() => { throw new Error("Network error"); });

const [success, users] = await getAllUsers();
expect(success).toBeFalsy();
Expand All @@ -69,140 +82,138 @@ describe("Function getAllUsers(filename: string) ", () => {
});
});

const newUser: NewUser = {
name: "New User",
password: "password",
role: "DST",
defaultServerPark: "gusty",
serverParks: ["gusty"]
};

describe("Function addNewUser(user: User) ", () => {

it("It should return true if the user has been created successfully", async () => {
mock_server_request_Return_JSON(201, {});
const success = await addNewUser(newUser);
expect(success).toBeTruthy();
});

it("It should return false if a password is not provided", async () => {
mock_server_request_Return_JSON(201, {});
const newUser: NewUser = {
defaultServerPark: "",
name: "username",
password: "",
role: "",
serverParks: []
};

const success = await addNewUser(newUser);
expect(success).toBeFalsy();
});

it("It should return false if a 404 is returned from the server", async () => {
mock_server_request_Return_JSON(404, []);
const success = await addNewUser(newUser);
expect(success).toBeFalsy();
});

it("It should return false if request returns an error code", async () => {
mock_server_request_Return_JSON(500, {});
const success = await addNewUser(newUser);
expect(success).toBeFalsy();
});

it("It should return false if request call fails", async () => {
mock_server_request_function(jest.fn(() => {
throw new Error("Network error");
}));

const success = await addNewUser(newUser);
expect(success).toBeFalsy();
});

afterAll(() => {
jest.clearAllMocks();
cleanup();
});
});

describe("Function deleteUser(username: string) ", () => {

const userToDelete = "dave01";

it("It should return true if the user has been deleted successfully", async () => {
mock_server_request_Return_JSON(204, {});
const success = await deleteUser(userToDelete);
expect(success).toBeTruthy();
});

it("It should return false if a 404 is returned from the server", async () => {
mock_server_request_Return_JSON(404, []);
const success = await deleteUser(userToDelete);
expect(success).toBeFalsy();
});

it("It should return false if request returns an error code", async () => {
mock_server_request_Return_JSON(500, {});
const success = await deleteUser(userToDelete);
expect(success).toBeFalsy();
});

it("It should return false if request call fails", async () => {
mock_server_request_function(jest.fn(() => {
throw new Error("Network error");
}));

const success = await deleteUser(userToDelete);
expect(success).toBeFalsy();
});

afterAll(() => {
jest.clearAllMocks();
cleanup();
});
});
// const newUser: NewUser = {
// name: "New User",
// password: "password",
// role: "DST",
// defaultServerPark: "gusty",
// serverParks: ["gusty"]
// };

// describe("Function addNewUser(user: User) ", () => {

// it("It should return true if the user has been created successfully", async () => {
// mock_server_request_Return_JSON(201, {});
// const success = await addNewUser(newUser);
// expect(success).toBeTruthy();
// });

// it("It should return false if a password is not provided", async () => {
// mock_server_request_Return_JSON(201, {});
// const newUser: NewUser = {
// defaultServerPark: "",
// name: "username",
// password: "",
// role: "",
// serverParks: []
// };

// const success = await addNewUser(newUser);
// expect(success).toBeFalsy();
// });

// it("It should return false if a 404 is returned from the server", async () => {
// mock_server_request_Return_JSON(404, []);
// const success = await addNewUser(newUser);
// expect(success).toBeFalsy();
// });

// it("It should return false if request returns an error code", async () => {
// mock_server_request_Return_JSON(500, {});
// const success = await addNewUser(newUser);
// expect(success).toBeFalsy();
// });

// it("It should return false if request call fails", async () => {
// mock_server_request_function(jest.fn(() => {
// throw new Error("Network error");
// }));

// const success = await addNewUser(newUser);
// expect(success).toBeFalsy();
// });

// afterAll(() => {
// jest.clearAllMocks();
// cleanup();
// });
// });

// describe("Function deleteUser(username: string) ", () => {

// const userToDelete = "dave01";

// it("It should return true if the user has been deleted successfully", async () => {
// mock_server_request_Return_JSON(204, {});
// const success = await deleteUser(userToDelete);
// expect(success).toBeTruthy();
// });

// it("It should return false if a 404 is returned from the server", async () => {
// mock_server_request_Return_JSON(404, []);
// const success = await deleteUser(userToDelete);
// expect(success).toBeFalsy();
// });

// it("It should return false if request returns an error code", async () => {
// mock_server_request_Return_JSON(500, {});
// const success = await deleteUser(userToDelete);
// expect(success).toBeFalsy();
// });

// it("It should return false if request call fails", async () => {
// mock_server_request_function(jest.fn(() => {
// throw new Error("Network error");
// }));

// const success = await deleteUser(userToDelete);
// expect(success).toBeFalsy();
// });

// afterAll(() => {
// jest.clearAllMocks();
// cleanup();
// });
// });

describe("Function editPassword(username: string, newPassword: string) ", () => {

const username = "testUser";
const newPassword = "password123";

it("It should return true if the password has been updated successfully", async () => {
mock_server_request_Return_JSON(204, {});
let promiseResponse: [number, JSON];

it("It should return true if the password has been updated successfully", async () => {
promiseResponse = [204, JSON.parse("{}")];
requestPromiseJsonMock.mockResolvedValue(promiseResponse);
const response = await editPassword(username, newPassword);
expect(response).toBeTruthy();
});

it("It should return false if a password is not provided", async () => {
const invalidPassword = "";

mock_server_request_Return_JSON(204, {});

const response = await editPassword(username, invalidPassword);
expect(response).toBeFalsy();
});

it("It should return false if a 404 is returned from the server", async () => {
mock_server_request_Return_JSON(404, []);

promiseResponse = [404, JSON.parse("{}")];
requestPromiseJsonMock.mockResolvedValue(promiseResponse);
const response = await editPassword(username, newPassword);
expect(response).toBeFalsy();
});

it("It should return false if request returns an error code", async () => {
mock_server_request_Return_JSON(500, {});
promiseResponse = [500, JSON.parse("{}")];
requestPromiseJsonMock.mockResolvedValue(promiseResponse);

const response = await editPassword(username, newPassword);
expect(response).toBeFalsy();
});

it("It should return false if request call fails", async () => {

mock_server_request_function(jest.fn(() => {
return Promise.reject(new Error("Network error"));
}));
requestPromiseJsonMock.mockRejectedValue(new Error('Async error'));

Check failure on line 216 in src/api/http/users.test.ts

View workflow job for this annotation

GitHub Actions / lint (20.x) 

Strings must use doublequote

const response = await editPassword(username, newPassword);
expect(response).toBeFalsy();
Expand Down

0 comments on commit dc309d9

Please sign in to comment.