Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user action component #4088

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

benfurber
Copy link
Member

@benfurber benfurber commented Jan 17, 2025

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes)

What is the new behavior?

A little util component to wrap around actions logged in user can do. Useful prep for #4044.
Reduces components that access the user store.

One small user change:
Screenshot 2025-01-17 at 14 35 31

Does this PR introduce a DB Schema Change or Migration?

  • Yes
  • No

Git Issues

Closes #4079

@benfurber
Copy link
Member Author

@davehakkens / @dalibormrska - Thoughts on updating the label for the sign-up buttons on the doc list pages?

Copy link

cypress bot commented Jan 17, 2025

onearmy-community-platform    Run #6817

Run Properties:  status check passed Passed #6817  •  git commit de81f4dedf: feat: add UserAction across app
Project onearmy-community-platform
Branch Review pull/4088
Run status status check passed Passed #6817
Run duration 05m 42s
Commit git commit de81f4dedf: feat: add UserAction across app
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 79
View all changes introduced in this branch ↗︎

@benfurber benfurber force-pushed the feat/user-action-component branch 4 times, most recently from 39aea26 to 2c0e91d Compare January 17, 2025 16:19
@dalibormrska
Copy link
Collaborator

@davehakkens / @dalibormrska - Thoughts on updating the label for the sign-up buttons on the doc list pages?

Makes sense, I think I missed this case to think it through there in the figma file.

I would just suggest using consistent language - Sign up to add your project

@benfurber benfurber force-pushed the feat/user-action-component branch 5 times, most recently from ca8bebf to 121fcd4 Compare January 21, 2025 10:18
@benfurber benfurber force-pushed the feat/user-action-component branch from 121fcd4 to de81f4d Compare January 22, 2025 11:08
@benfurber benfurber merged commit 13c9a8c into ONEARMY:master Jan 22, 2025
18 checks passed
@benfurber benfurber deleted the feat/user-action-component branch January 22, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] add user action util component
2 participants