Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Maps page Unit tests (Issue #1378) #1393

Closed
wants to merge 1 commit into from

Conversation

kfern
Copy link
Contributor

@kfern kfern commented Jan 18, 2022

PR Checklist

  • [ X] - Latest master branch merged
  • [ X] - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • [ X] Developer experience (improves developer workflows for contributing to the project)

Description

Unit tests is a "legacy todo". This PR is a starting point for a new unit tested Maps page.

Git Issues

#1378


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

@thisislawatts
Copy link
Collaborator

Marking as closed as we don't have the capacity to merge these changes at the moment. Broadly the approach looks great, incremental PRs are very welcome ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants