Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass using_checkpoint flag from ViTUnicomExtractor to VisionTransformer #614

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

korotaS
Copy link
Contributor

@korotaS korotaS commented Jul 4, 2024

  • I've checked contribution guide.

This PR fixes an error which was first discovered in #592 about exporting ViTUnicomExtractor to ONNX. The fix is simple but there is a question - is it enough to pass only using_checkpoint param or we can pass arbitrary params as **kwargs into VisionTransformer class? Also, do we need to test vitb16_unicom, vitl14_unicom and vitl14_336px_unicom or is it enough to test only one vitb32_unicom?

@AlekseySh
Copy link
Contributor

is it enough to pass only using_checkpoint param or we can pass arbitrary params as **kwargs into VisionTransformer class?

I think it's okay to keep only using_checkpoint at the moment

Also, do we need to test vitb16_unicom, vitl14_unicom and vitl14_336px_unicom or is it enough to test only one vitb32_unicom?

I think we don't want to have too much tests. If you tested them locally it's enough

@AlekseySh
Copy link
Contributor

AlekseySh commented Jul 4, 2024

  • Reminder: update the issue with an instruction after we merge it

Copy link
Contributor

@AlekseySh AlekseySh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for the contribution!

@AlekseySh AlekseySh merged commit 2ba9ed3 into OML-Team:main Jul 4, 2024
8 checks passed
@AlekseySh AlekseySh added rework good first issue Good for newcomers labels Jul 4, 2024
@AlekseySh AlekseySh linked an issue Jul 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers rework
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Can I export models to ONNX?
2 participants