Fix secrets usage and files cleanup #4
Conversation
| {{- if .Values.maildev.config.smtp.incoming.username }} | ||
| - name: MAILDEV_INCOMING_USER | ||
| value: {{ .Values.maildev.config.smtp.incoming.username | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
So does this mean if auth is required, but no username is provided, you still need to provide the smtp-incoming-password?
There was a problem hiding this comment.
Yes. That is the assumption I'm making b'se that is how the original Chart was. I assumed there is probably a default username the application assumes if nothing is provided. I'm not sure about the application behavior, so, I didn't deviate much from the original chart.
| nodePort: {{ .Values.services.smtp.nodePort }} | ||
| {{ end }} | ||
| {{- if (eq .Values.services.smtp.type "NodePort") }} | ||
| {{- if .Values.services.smtp.nodePort }} |
There was a problem hiding this comment.
Why reconstruct this way? Is the and operator not working ? Just curious.
There was a problem hiding this comment.
I didn't confidently understand the AND operation. Documentation Here.
and computes the Boolean AND of its arguments, returning the first false argument it encounters, or the last argument.
No description provided.