config/mt: Add vlan-tuple MT selector #9951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 6237 The VLAN tuple selector uses a tuple of values to select a tenant. - [ vlan-outermost, vlan-innermost] The tuple can contain as many VLAN values as supported by Suricata - currently 3. Each of these can accept a wild-card value (0). The tenant is selected by matching packet VLAN values with the selector values.
Show the default value used for the unix control socket instead of a generic name that's not used: custom.socket
jlucovsky
requested review from
jasonish,
inashivb,
jufajardini,
victorjulien and
a team
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9951 +/- ##
==========================================
- Coverage 82.35% 77.31% -5.05%
==========================================
Files 972 970 -2
Lines 273060 271448 -1612
==========================================
- Hits 224870 209859 -15011
- Misses 48190 61589 +13399
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16840 |
|
Continued in #9952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9747
Add a new MT selector type to support use cases where a VLAN tuple should be used to determine the MT tenant.
Packets with one VLAN id will never match as
vlan-tuplerequires at least QinQ.The tuple can hold up to 3 values -- this is the max supported by Suricata atm.
Tenants are selected by specifying a VLAN tuple, e.g.,
[1010, 5]. A packet matches when:10155Wild card values are supported; values of 0 match 'any VLAN' value in the same position as expressed in the tuple:
Tenants are selected by specifying a VLAN tuple, e.g.,
[1010, 0]. A packet matches when:1015Link to redmine ticket: 6237
Describe changes:
vlan-tuple-- for use cases where a VLAN pair should determines the tenant.Updates
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.