detect/asn1: handle in PMATCH #9932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the asn1 keyword is processing payload data, move the handling of the keyword into the PMATCH with content inspection. Use u32 as buffer length in the Rust FFI
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9932 +/- ##
==========================================
+ Coverage 82.35% 82.38% +0.03%
==========================================
Files 972 972
Lines 273060 273063 +3
==========================================
+ Hits 224870 224965 +95
+ Misses 48190 48098 -92
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16811 |
inashivb
approved these changes
Dec 4, 2023
|
|
||
| const DetectAsn1Data *ad = (const DetectAsn1Data *)smd->ctx; | ||
| Asn1 *asn1 = rs_asn1_decode(buffer, buffer_len, offset, ad); | ||
| uint8_t ret = rs_asn1_checks(asn1, ad); |
There was a problem hiding this comment.
Seems like this fn could also return bool
Merged
|
Merged in #9964, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the asn1 keyword is processing payload data, move the handling of the keyword into the PMATCH with content inspection.
Use u32 as buffer length in the Rust FFI
replaces #9922