-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect/asn1: handle in PMATCH #9932
Conversation
Since the asn1 keyword is processing payload data, move the handling of the keyword into the PMATCH with content inspection. Use u32 as buffer length in the Rust FFI
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9932 +/- ##
==========================================
+ Coverage 82.35% 82.38% +0.03%
==========================================
Files 972 972
Lines 273060 273063 +3
==========================================
+ Hits 224870 224965 +95
+ Misses 48190 48098 -92
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 16811 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀
|
||
const DetectAsn1Data *ad = (const DetectAsn1Data *)smd->ctx; | ||
Asn1 *asn1 = rs_asn1_decode(buffer, buffer_len, offset, ad); | ||
uint8_t ret = rs_asn1_checks(asn1, ad); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this fn could also return bool
Merged in #9964, thanks! |
Since the asn1 keyword is processing payload data, move the handling of the keyword into the PMATCH with content inspection.
Use u32 as buffer length in the Rust FFI
replaces #9922