-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment ac rust/v6 #9904
Closed
Closed
Experiment ac rust/v6 #9904
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
99f9179
mpm: cleanup pattern free function
victorjulien c2e4527
mpm: free sids in MpmFreePattern as well
victorjulien 1fca02d
ac/bs: reset sids pointer after xfer
victorjulien 47f2bc3
util/prefilter: constify sids
victorjulien 67bdeda
mpm/ac-rs: AC matcher based on aho-corasick crate
victorjulien 4e722ba
TEST default to mpm-algo=ac-rs for testing purposes
victorjulien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the unsafe notes from the previous PR... We've been doing C style naming for functions that form the C API recently.. So
SCMpmAcRsNewBuilder
or whatever.I guess this kind of breaks the way we've been looking at the impact of Rust functions tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions would not need to be part of a public C API. C API should only expose it through the generic MPM support. So would that mean we drop the SC?
MpmAcRsNewBuilder
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its no_mangle extern "C" its part of the public API, as far as linking goes which is why we want to name space under
SC
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm can we have a way to make things not public from a libsuri perspective? This stuff is public not because I want it to be, but because the C-Rust FFI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name, like
SCPrivate...
or_SC
to make it clear its for private use only. Additionally removing orifdef
out of the public headers, either would require some creative use or post-processing of the cbindgen output. The namespacing is to avoid a collision, and the name scheme or ifdef is to avoid unintentional linking. Nothing we can do about intentional linking.