general/cppcheck: Address cppcheck memory related errors #9849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address cppcheck reported memory leak/misuse errors. See the redmine issue for the cppcheck command that uncovered the issues. Issue: 6527
victorjulien
requested changes
Nov 20, 2023
| if (map->string) | ||
| SCFree(map->string); | ||
| SCFree(map); | ||
| BUG_ON(true); |
There was a problem hiding this comment.
Will modify function signature to return a bool and ensure the caller checks the return value.
|
Information: QA ran without warnings. Pipeline 16659 |
3 tasks
|
Continued in #9866 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address cppcheck reported memory leak/misuse errors. See the redmine issue for the cppcheck command that uncovered the issues.
Issue: 6527
Link to redmine ticket: 6527
Describe changes:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.