Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/194/20231119/v1 #9831

Merged
merged 3 commits into from
Nov 20, 2023
Merged

next/194/20231119/v1 #9831

merged 3 commits into from
Nov 20, 2023

Conversation

victorjulien
Copy link
Member

thomasjwinter and others added 3 commits November 19, 2023 07:25
@thomasjwinter @victorjulien
rule-reload: Release excess memory freed during engine reload
7d40a9f 
The hot reload results in large chunks of memory being freed as the
as the old signature tables are discarded. Help the memory management
system along by telling to release as much memory as it can at this
point.

Bug: OISF#6454.
@jmtaylor90 @victorjulien
doc: update file.data keyword documentation
c500029 
Signed-off-by: jason taylor <jtfas90@gmail.com>
@regit @victorjulien
detect/stream_size: fix prefiltering registration
180459e 
Ticket: OISF#6551
@codecov Codecov
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Merging #9831 (180459e) into master (d2b25af) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9831   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         972      972           
  Lines      273929   273932    +3     
=======================================
+ Hits       225788   225802   +14     
+ Misses      48141    48130   -11
Flag Coverage Δ
fuzzcorpus 64.32% <80.00%> (+0.03%) ⬆️
suricata-verify 61.06% <20.00%> (-0.03%) ⬇️
unittests 62.88% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 16632

inashivb
inashivb reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit inline, rest looks good.

inashivb
inashivb approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nit came from the original PR. Nothing changed in this one. Since that was approved, setting this to approved too.

@victorjulien victorjulien merged commit 180459e into OISF:master Nov 20, 2023
45 checks passed
This was referenced Nov 20, 2023
Closed
Closed
Closed
@victorjulien victorjulien deleted the next/194/20231119/v1 branch June 23, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@victorjulien @suricata-qa @inashivb @thomasjwinter @jmtaylor90 @regit